Fix dtrace probes for TCPDEBUG
ClosedPublic
Actions

Authored by hannes_mehnert.org on Mar 2 2016, 8:29 PM.

Details

Reviewers

hiren
rrs
jtl
gnn

Group Reviewers

transport

Commits

rS296352: Fix dtrace probes (introduced in 287759): debug__input was used

Summary

Fix dtrace probes (introduced by gnn@ in 287759): debug__input was used
for output and drop; connect didn't always fire a user probe; some probes
were missing in fastpath

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2739
Build 2760: arc lint + arc unit

Event Timeline

hannes_mehnert.org updated this revision to Diff 13997.Mar 2 2016, 8:29 PM

hannes_mehnert.org retitled this revision from to Fix dtrace probes for TCPDEBUG.

hannes_mehnert.org updated this object.

hannes_mehnert.org edited the test plan for this revision. (Show Details)

hannes_mehnert.org added a reviewer: gnn.

Herald added a reviewer: transport. · View Herald TranscriptMar 2 2016, 8:29 PM

Herald added a subscriber: imp. · View Herald Transcript

gnn added reviewers: rrs, jtl, hiren.Mar 3 2016, 2:48 AM

My motivation is to use dtrace instead of TCPDEBUG, thus I complemented every tcp_trace with a TCP_PROBE afterwards (some were missing). Moving around the m_free(m) is solely to have the consistency of #ifdef TCPDEBUG.. #endif followed by TCP_PROBE (if you prefer, the TCP_PROBE can be moved upwards, and the m_free stay at the same place as before.