Page MenuHomeFreeBSD

rc.d/nscd: Avoid using setvar
Needs ReviewPublic

Authored by temcbun_gmail.com on Feb 3 2026, 8:38 PM.
Referenced Files
Unknown Object (File)
Mon, Jun 8, 10:26 PM
Unknown Object (File)
Mon, Jun 8, 10:33 AM
Unknown Object (File)
Thu, Jun 4, 7:50 PM
Unknown Object (File)
Thu, Jun 4, 7:50 PM
Unknown Object (File)
Mon, May 18, 1:19 AM
Unknown Object (File)
Mon, May 18, 1:13 AM
Unknown Object (File)
Sun, May 17, 12:45 PM
Unknown Object (File)
Sat, May 16, 6:33 PM
Subscribers

Details

Reviewers
0mp
markj
cy
Group Reviewers
Contributor Reviews (src)
Summary

setvar is a non-standard feature of sh(1) and thus is not portable.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

temcbun_gmail.com added a reviewer: cy.

I don't think there's any expectation that the rc scripts will be portable, but when there's no material difference (e.g. in performance, clarity, maintainability, etc.) I agree we should indeed prefer the portable way.

I don't think there's any expectation that the rc scripts will be portable, but when there's no material difference (e.g. in performance, clarity, maintainability, etc.) I agree we should indeed prefer the portable way.

I also think so. Besides, the rest of the rc scripts are using this construction instead of setvar. It lingers around only in two places: here and in rc.subr (https://reviews.freebsd.org/D55086).