Page MenuHomeFreeBSD
Differential D55061

netgraph/ksocket tests: Bind to IN6ADDR_LOOPBACK
AbandonedPublic
Actions

Authored by emaste on Mon, Feb 2, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 3, 8:21 PM
Unknown Object (File)
Tue, Feb 3, 2:25 PM
Unknown Object (File)
Tue, Feb 3, 12:44 PM
Unknown Object (File)
Tue, Feb 3, 11:56 AM
Unknown Object (File)
Tue, Feb 3, 11:49 AM
Unknown Object (File)
Tue, Feb 3, 7:06 AM
Unknown Object (File)
Tue, Feb 3, 6:28 AM
Unknown Object (File)
Tue, Feb 3, 6:27 AM
Subscribers
donner
glebius
melifaro

Details

Reviewers
zlei
markj
Summary
We no longer allow connect()ing to IN6ADDR_ANY as of commit
627e126dbb07.

Fixes: 627e126dbb07 ("netinet6: Disallow connections to IN6ADDR_ANY")
Reported by:    zlei

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Mon, Feb 2, 7:38 PM
Herald added subscribers: glebius, melifaro, donner. · View Herald TranscriptMon, Feb 2, 7:38 PM
emaste requested review of this revision.Mon, Feb 2, 7:38 PM
markj added inline comments.Mon, Feb 2, 7:53 PM
tests/sys/netgraph/ksocket.c
121–123

Don't you need it here too?

emaste updated this revision to Diff 171016.Mon, Feb 2, 7:57 PM

udp6_connect too

tests/sys/netgraph/ksocket.c
121–123

And populate sin6_len while here, too.

markj accepted this revision.Mon, Feb 2, 8:20 PM
This revision is now accepted and ready to land.Mon, Feb 2, 8:20 PM
emaste abandoned this revision.Mon, Feb 2, 8:26 PM

@glebius committed equivalent change in 32c3723f06554db7d0da49c6f361c7b8f1a394c1

glebius added a comment.Mon, Feb 2, 8:37 PM

Oops, sorry. If the reviews.freebsd.org mailbox was open in mutt while I was fixing the test, then I would not jump in front of you.

Revision Contents
Changeset List

PathSize
tests/
sys/
netgraph/
3 lines

Diff 171016

View Options

tests/sys/netgraph/ksocket.c

Loading...