Differential D5505

if_dwc add reset-gpio
ClosedPublic
Actions

Authored by manu_bidouilliste.com on Mar 1 2016, 11:58 AM.

Tags

Referenced Files

	Unknown Object (File)
	Mon, Dec 2, 1:51 PM

	Unknown Object (File)
	Fri, Nov 22, 12:13 PM

	Unknown Object (File)
	Oct 30 2024, 4:11 AM

	Unknown Object (File)
	Oct 19 2024, 5:07 PM

	Unknown Object (File)
	Oct 17 2024, 2:33 AM

	Unknown Object (File)
	Oct 8 2024, 9:37 AM

	Unknown Object (File)
	Oct 8 2024, 3:45 AM

	Unknown Object (File)
	Oct 8 2024, 3:21 AM

Subscribers

Details

Reviewers

jmcneill
andrew
adrian

Group Reviewers

Commits

rS296365: Add support for resetting the PHY via GPIO.

Summary

The snps have some optional property for reseting the phy via gpios.
This patch implement the reset.

Test Plan

Apply patch and test on systems with dwc

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu_bidouilliste.com updated this revision to Diff 13928.Mar 1 2016, 11:58 AM

manu_bidouilliste.com retitled this revision from to if_dwc add reset-gpio.

manu_bidouilliste.com updated this object.

manu_bidouilliste.com edited the test plan for this revision. (Show Details)

manu_bidouilliste.com added a reviewer: ARM.

manu_bidouilliste.com set the repository for this revision to rS FreeBSD src repository - subversion.

manu_bidouilliste.com added a project: ARM.

Herald added subscribers: loos, imp. · View Herald TranscriptMar 1 2016, 11:58 AM

jmcneill added a subscriber: jmcneill.Mar 1 2016, 12:52 PM

jmcneill added inline comments.

sys/dev/dwc/if_dwc.c
1027 ↗	(On Diff #13928)	Indent 4 spaces instead of a tab for multi-line if condition.
1031 ↗	(On Diff #13928)	4 spaces here too
1044 ↗	(On Diff #13928)	Instead of active_low = 0/1 it would simplify the GPIO_PIN_SET calls later if you had int value and set it to either GPIO_PIN_LOW/GPIO_PIN_HIGH
1047 ↗	(On Diff #13928)	4 spaces here too

Simplify the active_low logic.

manu_bidouilliste.com marked 4 inline comments as done.Mar 1 2016, 1:58 PM

Respect optional pin polarity.

br added a subscriber: br.Mar 1 2016, 6:06 PM

br added inline comments.

sys/dev/dwc/if_dwc.c
1041 ↗	(On Diff #13937)	line is too long

Fix style(9)

manu_bidouilliste.com marked an inline comment as done.Mar 2 2016, 7:05 AM

jmcneill accepted this revision.Mar 2 2016, 9:49 PM

jmcneill added a reviewer: jmcneill.

This revision is now accepted and ready to land.Mar 2 2016, 9:49 PM

andrew accepted this revision.Mar 3 2016, 11:08 AM

andrew added a reviewer: andrew.

adrian accepted this revision.Mar 3 2016, 9:54 PM

adrian added a reviewer: adrian.

Closed by commit rS296365: Add support for resetting the PHY via GPIO. (authored by jmcneill). · Explain WhyMar 3 2016, 10:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

dwc/

64 lines

Diff 14049

head/sys/dev/dwc/if_dwc.c

Loading...