x86: x86_msr_op(): Add comments, cosmetic changes
Needs ReviewPublic
Actions

Authored by olce on Sat, Jan 31, 11:30 AM.

Details

Reviewers

markj
kib

Summary

In 3 small commits, grouped here:

x86: x86_msr_op(): Move setting mode up, delineate logical blocks

No functional changes (intended).

x86: x86_msr_op(): Simplify assertions

Simplify them by moving them into more natural places, i.e., default
cases of 'switch' statements.

No functional change (intended).

x86: x86_msr_op(): Caution about using MSR_OP_LOCAL

No functional change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70268
Build 67151: arc lint + arc unit

Event Timeline

olce created this revision.Sat, Jan 31, 11:30 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Jan 31, 11:30 AM

olce requested review of this revision.Sat, Jan 31, 11:30 AM

Harbormaster completed remote builds in B70268: Diff 170831.Sat, Jan 31, 11:30 AM

olce retitled this revision from x86: x86_msr_op(): Move setting mode up, delineate logical blocks to x86: x86_msr_op(): Add comments, cosmetic changes.Sat, Jan 31, 11:32 AM

olce edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

Path

Size

sys/

x86/

include/

x86_var.h

7 lines

x86/

cpu_machdep.c

17 lines

Diff 170831

View Options

sys/x86/include/x86_var.h