ure: improve checksum offloading
ClosedPublic
Actions

Authored by tuexen on Fri, Jan 30, 4:36 PM.

Details

Reviewers

kevlo
jhibbits
timo.voelker_fh-muenster.de

Commits

rG7b6e84c9ac56: ure: improve checksum offloading

Summary

This patch fixes three issues:
(1) Initially, set the hwassist flags correctly when enabling transmit checksum offload for TCP/IPv6 and UDP/IPv6.
(2) Keep the hwassist flags in sync with the capabilities when changing txcsum.
(3) Keep the hwasssit flags in sync with the capabilities when changing txcsum6.

Without this patch, transmit checksum offloading for TCP/IPv6 and UDP/IPv6 is never used and transmit checksum offloading for IPv4, TCP/IPv4 and UDP/IPv4 is always used, even if disabled via ifconfig ue? -txcsum.

Test Plan

Tested with the ethernet interface on a Framebook.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Fri, Jan 30, 4:36 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 30, 4:36 PM

tuexen requested review of this revision.Fri, Jan 30, 4:36 PM

tuexen edited the summary of this revision. (Show Details)Fri, Jan 30, 4:42 PM

Without this patch, transmit checksum offloading for TCP/IPv6 and UDP/IPv6 is never used and transmit checksum offloading for IPv4, TCP/IPv4 and UDP/IPv4 is always used, even if disabled via ifconfig ue? -txcsum.

I haven't tested it but that is probably what happens. This patch adds the lines needed to fix that.

This revision is now accepted and ready to land.Sat, Jan 31, 9:01 AM

Closed by commit rG7b6e84c9ac56: ure: improve checksum offloading (authored by tuexen). · Explain WhySat, Jan 31, 10:45 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG7b6e84c9ac56: ure: improve checksum offloading.