Page MenuHomeFreeBSD
Differential D5494

Force PCI bus interrupt rerouting
ClosedPublic
Actions

Authored by bz on Feb 29 2016, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 17 2024, 4:53 AM
Unknown Object (File)
Nov 17 2024, 4:52 AM
Unknown Object (File)
Nov 4 2024, 4:37 AM
Unknown Object (File)
Sep 29 2024, 1:45 AM
Unknown Object (File)
Sep 7 2024, 1:45 AM
Unknown Object (File)
Jun 21 2024, 8:28 PM
Unknown Object (File)
Jun 15 2024, 11:44 PM
Unknown Object (File)
May 21 2024, 9:40 AM
View All 53 Files
Subscribers
emaste
imp

Details

Reviewers
jhb
andrew
Commits
rS296315: Force re-routing PCI interrupts (this is for legacy INTx not MSI).
Summary

Seems to be needed for at least gem5. Someone should explain this and see if it's correct to add it or not.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz updated this revision to Diff 13887.Feb 29 2016, 4:42 PM
bz retitled this revision from to Force PCI bus interrupt rerouting.
bz updated this object.
bz edited the test plan for this revision. (Show Details)
bz added reviewers: andrew, jhb.
bz set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 29 2016, 4:42 PM
andrew accepted this revision.Mar 1 2016, 12:02 PM
andrew edited edge metadata.
andrew added inline comments.
sys/arm64/include/param.h
45 ↗(On Diff #13887)

Should be #define<tab>__PCI...

This revision is now accepted and ready to land.Mar 1 2016, 12:02 PM
bz added inline comments.Mar 1 2016, 1:12 PM
sys/arm64/include/param.h
45 ↗(On Diff #13887)

ACK, will check before committing.

jhb edited edge metadata.Mar 1 2016, 9:05 PM

In theory all platforms should do this if their PCI bridge drivers know how to manage routing. Note also that this only matters for legacy INTx interrupts, not MSI.

andrew added a comment.Mar 2 2016, 9:16 AM
In D5494#117542, @jhb wrote:

In theory all platforms should do this if their PCI bridge drivers know how to manage routing. Note also that this only matters for legacy INTx interrupts, not MSI.

I think we missed this because we've always used MSI/MSI-X interrupts on arm64.

Closed by commit rS296315: Force re-routing PCI interrupts (this is for legacy INTx not MSI). (authored by bz). · Explain WhyMar 2 2016, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
include/
2 lines

Diff 13985

View Options

head/sys/arm64/include/param.h

Loading...