Page MenuHomeFreeBSD
Differential D54935

etcupdate: Do not ignore empty files.
ClosedPublic
Actions

Authored by delphij on Thu, Jan 29, 3:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 3, 11:12 AM
Unknown Object (File)
Tue, Feb 3, 3:54 AM
Unknown Object (File)
Thu, Jan 29, 1:51 PM
Unknown Object (File)
Thu, Jan 29, 1:14 PM
Unknown Object (File)
Thu, Jan 29, 5:20 AM
Unknown Object (File)
Thu, Jan 29, 5:01 AM
Unknown Object (File)
Thu, Jan 29, 4:54 AM
Unknown Object (File)
Thu, Jan 29, 4:43 AM
View All 9 Files
Subscribers
imp

Details

Reviewers
jhb
markj
emaste
jrtc27
Commits
rG4f7336a93cb8: etcupdate: Do not ignore empty files.
Summary

PR: bin/292773
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

delphij created this revision.Thu, Jan 29, 3:32 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, Jan 29, 3:32 AM
delphij requested review of this revision.Thu, Jan 29, 3:32 AM
Harbormaster completed remote builds in B70202: Diff 170671.Thu, Jan 29, 3:32 AM
markj added a comment.Thu, Jan 29, 1:57 PM

I'm not very familiar with etcupdate internals but this seems reasonable to me. OTOH I don't know what clutter the comment is referring to.

It'd be nice to add a regression test for this.

usr.sbin/etcupdate/etcupdate.sh
250

Presumably this comment needs to be updated too?

delphij updated this revision to Diff 170824.Sat, Jan 31, 4:13 AM

Add regression test for installing empty files.

Verified with the change reverted and applied.

Harbormaster completed remote builds in B70265: Diff 170824.Sat, Jan 31, 4:13 AM
delphij marked an inline comment as done.Sat, Jan 31, 4:15 AM
delphij added inline comments.
usr.sbin/etcupdate/etcupdate.sh
250

I think the comment is still true (we still ignore generated files, and comment didn't explicitly say empty files)...

markj added a reviewer: jrtc27.Sat, Jan 31, 11:16 PM
markj accepted this revision.Mon, Feb 2, 2:11 PM

Seems ok to me. You might give a few days for other reviewers to chime in.

This revision is now accepted and ready to land.Mon, Feb 2, 2:11 PM
Closed by commit rG4f7336a93cb8: etcupdate: Do not ignore empty files. (authored by delphij). · Explain WhyThu, Feb 5, 3:45 AM
This revision was automatically updated to reflect the committed changes.
delphij marked an inline comment as done.
delphij added a commit: rG4f7336a93cb8: etcupdate: Do not ignore empty files..

Revision Contents
Changeset List

PathSize
usr.sbin/
etcupdate/
4 lines
tests/
1 line
86 lines

Diff 171190

View Options

usr.sbin/etcupdate/etcupdate.sh

Loading...
View Options

usr.sbin/etcupdate/tests/Makefile

Loading...
View Options

usr.sbin/etcupdate/tests/empty_file_test.sh

Loading...