Page MenuHomeFreeBSD
Differential D54894

wlanstat: Drop unneeded bsd.compiler.mk from Makefile
ClosedPublic
Actions

Authored by jhb on Jan 26 2026, 4:25 PM.
Tags
None
Referenced Files
F167168558: D54894.id170861.diff
Wed, Aug 19, 3:27 PM
Unknown Object (File)
Tue, Aug 18, 9:36 PM
Unknown Object (File)
Mon, Aug 17, 2:35 PM
Unknown Object (File)
Sun, Aug 16, 10:51 AM
Unknown Object (File)
Thu, Aug 13, 10:44 AM
Unknown Object (File)
Thu, Aug 13, 12:13 AM
Unknown Object (File)
Wed, Aug 12, 12:21 AM
Unknown Object (File)
Mon, Aug 10, 11:33 PM
View All 72 Files
Subscribers
brooks
imp

Details

Reviewers
bz
jrtc27
emaste
brooks
Group Reviewers
cheri
Commits
rG6ca22d1666be: wlanstat: Drop unneeded bsd.compiler.mk from Makefile
rG6e82cb290667: wlanstat: Drop unneeded bsd.compiler.mk from Makefile
Summary

NFC, but downstream in CheriBSD this was causing a link error as the
Makefile was overriding CFLAGS set via a side effect of
bsd.compiler.mk.

Sponsored by: AFRL, DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jan 26 2026, 4:25 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 26 2026, 4:25 PM
jhb requested review of this revision.Jan 26 2026, 4:25 PM
Harbormaster completed remote builds in B70145: Diff 170470.Jan 26 2026, 4:25 PM
Herald added a reviewer: cheri. · View Herald TranscriptJan 26 2026, 4:25 PM
Herald added a reviewer: cheri. · View Herald Transcript
bz accepted this revision.Jan 26 2026, 4:49 PM

Sorry, I am a bit slow; what does NFC in the proposed commit message stand for? Not For Commit? No Functional Change? Care to expand before commit?

This revision is now accepted and ready to land.Jan 26 2026, 4:49 PM
emaste accepted this revision.Jan 26 2026, 4:53 PM
brooks accepted this revision.Jan 27 2026, 9:26 AM
brooks added a subscriber: brooks.

NFC = "No functional change" in this context.

Closed by commit rG6e82cb290667: wlanstat: Drop unneeded bsd.compiler.mk from Makefile (authored by jhb). · Explain WhyJan 31 2026, 4:59 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG6e82cb290667: wlanstat: Drop unneeded bsd.compiler.mk from Makefile.
jhb added a commit: rG6ca22d1666be: wlanstat: Drop unneeded bsd.compiler.mk from Makefile.Apr 24 2026, 3:29 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
wlanstat/
2 lines

Diff 170861

View Options

usr.sbin/wlanstat/Makefile

Loading...