Page MenuHomeFreeBSD
Differential D54894

wlanstat: Drop unneeded bsd.compiler.mk from Makefile
AcceptedPublic
Actions

Authored by jhb on Mon, Jan 26, 4:25 PM.
Tags
None
Referenced Files
F143404794: D54894.diff
Fri, Jan 30, 1:31 AM
Unknown Object (File)
Tue, Jan 27, 6:19 AM
Unknown Object (File)
Tue, Jan 27, 4:47 AM
Unknown Object (File)
Tue, Jan 27, 2:47 AM
Unknown Object (File)
Mon, Jan 26, 11:55 PM
Unknown Object (File)
Mon, Jan 26, 6:29 PM
Unknown Object (File)
Mon, Jan 26, 6:24 PM
Subscribers
brooks
imp

Details

Reviewers
bz
jrtc27
emaste
brooks
Group Reviewers
cheri
Summary

NFC, but downstream in CheriBSD this was causing a link error as the
Makefile was overriding CFLAGS set via a side effect of
bsd.compiler.mk.

Sponsored by: AFRL, DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70145
Build 67028: arc lint + arc unit

Event Timeline

jhb created this revision.Mon, Jan 26, 4:25 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 26, 4:25 PM
jhb requested review of this revision.Mon, Jan 26, 4:25 PM
Harbormaster completed remote builds in B70145: Diff 170470.Mon, Jan 26, 4:25 PM
Herald added a reviewer: cheri. · View Herald TranscriptMon, Jan 26, 4:25 PM
Herald added a reviewer: cheri. · View Herald Transcript
bz accepted this revision.Mon, Jan 26, 4:49 PM

Sorry, I am a bit slow; what does NFC in the proposed commit message stand for? Not For Commit? No Functional Change? Care to expand before commit?

This revision is now accepted and ready to land.Mon, Jan 26, 4:49 PM
emaste accepted this revision.Mon, Jan 26, 4:53 PM
brooks accepted this revision.Tue, Jan 27, 9:26 AM
brooks added a subscriber: brooks.

NFC = "No functional change" in this context.

Revision Contents
Changeset List

PathSize
usr.sbin/
wlanstat/
2 lines

Diff 170470

View Options

usr.sbin/wlanstat/Makefile

Loading...