Differential D54862

Add posix_spawnattr_get/setexecfd_np(3)
ClosedPublic
Actions

Authored by kib on Sat, Jan 24, 10:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 16, 12:49 AM

	Unknown Object (File)
	Thu, Feb 12, 8:04 AM

	Unknown Object (File)
	Tue, Feb 10, 4:20 PM

	Unknown Object (File)
	Tue, Feb 10, 11:17 AM

	Unknown Object (File)
	Sun, Feb 8, 7:16 PM

	Unknown Object (File)
	Tue, Feb 3, 2:01 PM

	Unknown Object (File)
	Mon, Feb 2, 3:22 AM

	Unknown Object (File)
	Fri, Jan 30, 11:32 PM

View All 20 Files

Subscribers

Details

Reviewers

asomers
markj
emaste

Commits

rG58580dc0c694: libc: document posix_spawnattr_getexecfd_np(3)
rG3f0aea09689f: libc: add posix_spawnattr_{get,set}execfd_np(3)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sat, Jan 24, 10:24 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptSat, Jan 24, 10:24 PM

kib requested review of this revision.Sat, Jan 24, 10:24 PM

Some fixes, mostly to the man page typos.
Also accept that spawnattrs might be NULL.

markj added inline comments.Sun, Jan 25, 4:02 PM

lib/libc/gen/posix_spawnattr_getexecfd_np.3
14 ↗	(On Diff #170359)	posix_spawn.3 should xref this page in the SEE ALSO section.
46 ↗	(On Diff #170359)
47 ↗	(On Diff #170359)
48 ↗	(On Diff #170359)	What's wrong with having O_CLOEXEC set? Doesn't fexecve() work in this case? I didn't test it, but I see that do_execve() acquires a ref on the textvp before calling fdcloseexec(). Certainly O_CLOFORK must not be set.
52 ↗	(On Diff #170359)
85 ↗	(On Diff #170359)

kib marked 6 inline comments as done.Sun, Jan 25, 4:18 PM

kib added inline comments.

lib/libc/gen/posix_spawnattr_getexecfd_np.3
48 ↗	(On Diff #170359)	Of course it is CLOFORK. My bad, I had some discussion about some patch with the CLOFORK author simultaneously and it obviously get mixed.

Man page fixes

markj accepted this revision.Sun, Jan 25, 5:16 PM

This revision is now accepted and ready to land.Sun, Jan 25, 5:16 PM

Closed by commit rG3f0aea09689f: libc: add posix_spawnattr_{get,set}execfd_np(3) (authored by kib). · Explain WhySun, Jan 25, 5:21 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG3f0aea09689f: libc: add posix_spawnattr_{get,set}execfd_np(3).

kib added a commit: rG58580dc0c694: libc: document posix_spawnattr_getexecfd_np(3).

Revision Contents
Changeset List

Path

Size

include/

7 lines

lib/

libc/

gen/

5 lines

22 lines

Diff 170407

include/spawn.h

Loading...

lib/libc/gen/Symbol.map

Loading...

lib/libc/gen/posix_spawn.c

Loading...