Page MenuHomeFreeBSD

dpaa2: cleanup
ClosedPublic

Authored by tuexen on Jan 20 2026, 8:14 PM.
Tags
None
Referenced Files
F147810168: D54805.diff
Fri, Mar 13, 8:27 PM
Unknown Object (File)
Mon, Mar 9, 11:18 AM
Unknown Object (File)
Mon, Feb 23, 7:46 PM
Unknown Object (File)
Feb 10 2026, 11:54 AM
Unknown Object (File)
Feb 8 2026, 11:14 AM
Unknown Object (File)
Feb 8 2026, 9:32 AM
Unknown Object (File)
Feb 7 2026, 10:23 PM
Unknown Object (File)
Jan 31 2026, 1:20 PM
Subscribers

Details

Summary

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz added a subscriber: bz.

Functionally accepted.

sys/dev/dpaa2/dpaa2_ni.c
2601–2604

Style would say this should be checked against != 0

If we are touching it, we should fix it ;-)

2603

dito

This revision is now accepted and ready to land.Jan 20 2026, 8:18 PM

PS: I should really go and read the specs to see if we can steer v4 and v6 independently but my memory says we cannot.

Address style comment raised by bz.

This revision now requires review to proceed.Jan 20 2026, 8:30 PM
tuexen added inline comments.
sys/dev/dpaa2/dpaa2_ni.c
2601–2604

Both fixed.

This revision is now accepted and ready to land.Jan 20 2026, 9:10 PM
This revision was automatically updated to reflect the committed changes.

Seems to improve the code. Less lines and it looks less complex. This changes the functionality only if IFCAP_RXCSUM and IFCAP_RXCSUM_IPV6 or IFCAP_TXCSUM and IFCAP_TXCSUM_IPV6 get out of sync but, in my understanding of the code, this cannot happen.