Page MenuHomeFreeBSD

net80211: in net80211_vap_printf() also use vprintf()
Needs ReviewPublic

Authored by bz on Tue, Jan 20, 1:54 PM.
Tags
None
Referenced Files
F142559105: D54795.diff
Wed, Jan 21, 12:10 AM
F142558096: D54795.id.diff
Tue, Jan 20, 11:52 PM
F142553976: D54795.id.diff
Tue, Jan 20, 10:39 PM
F142544357: D54795.diff
Tue, Jan 20, 8:16 PM
F142542617: D54795.id170120.diff
Tue, Jan 20, 7:47 PM
F142539495: D54795.id170133.diff
Tue, Jan 20, 6:51 PM

Details

Reviewers
None
Group Reviewers
wireless
Summary

While everything else uses vprintf() and net80211_vap_printf()
vlog() the debug output of wlandebug sessions can be weird.
For consistency use vprintf() everywhere to have homogeneous logging.

Sponosred by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70023
Build 66906: arc lint + arc unit

Event Timeline

bz requested review of this revision.Tue, Jan 20, 1:54 PM
emaste added inline comments.
sys/net80211/ieee80211_freebsd.c
1327

Any reason to keep this commented out?

sys/net80211/ieee80211_freebsd.c
1327

Question is whether we want to, at some point, migrate them all to vlog or rather not? See the function below for Adrian's comments left.

I left it as a reminder that there was a problem with it. I had concerns on the previous review.
We need an overall strategy for this (and debug logging, which ideally would go elsewhere... or cease to be printf).

I can remove it though if you want. The problem will stay on the stack in my head.

In some ways this is (and I should add it to the commit message):
Fixes: 0861daf511dc9

Rather than leaving the vlog as a reminder, deal with the TODO comment
in net80211_ic_printf() as well and remove the vlog comment from there.