syslogd/tests: Use a helper function to log from within a jail
ClosedPublic
Actions

Authored by markj on Mon, Jan 19, 3:41 PM.

Details

Reviewers

jfree
jlduran

Commits

rGc55fcf37e52c: syslogd/tests: Use a helper function to log from within a jail
rGffdbc1bc2170: syslogd/tests: Use a helper function to log from within a jail

Summary

This is just for consistency with all other logger(1) invocations, which
happen from the syslogd_log() function.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jan 19, 3:41 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 19, 3:41 PM

markj requested review of this revision.Mon, Jan 19, 3:41 PM

Harbormaster completed remote builds in B69984: Diff 170043.Mon, Jan 19, 3:41 PM

markj added a child revision: D54779: syslogd/tests: Address races.Mon, Jan 19, 3:41 PM

After this refactoring, the test syslogd_test:forward becomes very flaky. It should be all fixed in the following revision.

This revision is now accepted and ready to land.Mon, Jan 19, 8:04 PM

Closed by commit rGffdbc1bc2170: syslogd/tests: Use a helper function to log from within a jail (authored by markj). · Explain WhyThu, Jan 22, 5:18 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGffdbc1bc2170: syslogd/tests: Use a helper function to log from within a jail.

markj added a commit: rGc55fcf37e52c: syslogd/tests: Use a helper function to log from within a jail.Mon, Feb 9, 6:04 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

tests/

syslogd_test.sh

60 lines

syslogd_test_common.sh

7 lines

Diff 170244

View Options

usr.sbin/syslogd/tests/syslogd_test.sh