Page MenuHomeFreeBSD

syslogd/tests: Fix flakiness in forwarding tests
ClosedPublic

Authored by markj on Tue, Jan 20, 5:10 PM.
Tags
None
Referenced Files
F144708152: D54800.id170139.diff
Wed, Feb 11, 11:33 AM
Unknown Object (File)
Sun, Feb 8, 3:04 PM
Unknown Object (File)
Sun, Feb 8, 12:21 PM
Unknown Object (File)
Sun, Feb 8, 6:17 AM
Unknown Object (File)
Fri, Feb 6, 8:51 PM
Unknown Object (File)
Tue, Feb 3, 4:02 PM
Unknown Object (File)
Mon, Feb 2, 2:01 AM
Unknown Object (File)
Mon, Feb 2, 2:01 AM
Subscribers

Details

Summary

syslogd_start() waits for the local log socket to appear before
returning, to ensure that the daemon is ready to handle log messages.
Some tests start two daemons, so by default the socket already exists
when the second daemon is started, so syslogd_start() returns early.
The test subsequently sends a message to this second daemon, which
sometimes isn't ready.

Define a separate log socket for the second daemon. Add a check to
syslogd_start() to help catch this type of bug.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I've seen that when using ATF, ${PWD} is preferred over $(pwd) (efficiency, I guess).

This revision is now accepted and ready to land.Tue, Jan 20, 5:58 PM
This revision now requires review to proceed.Tue, Jan 20, 7:28 PM
This revision is now accepted and ready to land.Tue, Jan 20, 7:52 PM