Page MenuHomeFreeBSD

syslogd/tests: Fix flakiness in forwarding tests
ClosedPublic

Authored by markj on Jan 20 2026, 5:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 6, 6:46 PM
Unknown Object (File)
Mon, Mar 2, 3:18 PM
Unknown Object (File)
Wed, Feb 25, 1:55 PM
Unknown Object (File)
Tue, Feb 24, 5:47 AM
Unknown Object (File)
Sat, Feb 21, 12:06 PM
Unknown Object (File)
Fri, Feb 20, 5:33 PM
Unknown Object (File)
Fri, Feb 20, 5:33 PM
Unknown Object (File)
Wed, Feb 18, 10:32 PM
Subscribers

Details

Summary

syslogd_start() waits for the local log socket to appear before
returning, to ensure that the daemon is ready to handle log messages.
Some tests start two daemons, so by default the socket already exists
when the second daemon is started, so syslogd_start() returns early.
The test subsequently sends a message to this second daemon, which
sometimes isn't ready.

Define a separate log socket for the second daemon. Add a check to
syslogd_start() to help catch this type of bug.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I've seen that when using ATF, ${PWD} is preferred over $(pwd) (efficiency, I guess).

This revision is now accepted and ready to land.Jan 20 2026, 5:58 PM
This revision now requires review to proceed.Jan 20 2026, 7:28 PM
This revision is now accepted and ready to land.Jan 20 2026, 7:52 PM