Page MenuHomeFreeBSD

capsicum.4: Replace 'fi' ligature and smart quotation mark
AcceptedPublic

Authored by tembun_bk.ru on Sat, Jan 17, 9:27 PM.
Referenced Files
F142451465: D54761.diff
Tue, Jan 20, 2:36 AM
F142426020: D54761.id.diff
Mon, Jan 19, 9:02 PM
F142385213: D54761.diff
Mon, Jan 19, 10:24 AM
Unknown Object (File)
Mon, Jan 19, 5:35 AM
Unknown Object (File)
Sun, Jan 18, 3:44 AM
Unknown Object (File)
Sun, Jan 18, 1:12 AM
Unknown Object (File)
Sat, Jan 17, 10:50 PM
Unknown Object (File)
Sat, Jan 17, 10:48 PM
Subscribers

Details

Reviewers
ziaee
jlduran
Group Reviewers
docs
manpages
Summary

While here, wrap the line to 80 characters.

Fixes: c54534e60263 ("capsicum.4: Add some more detail from the Capsicum paper")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I guess that it would be a good idea to add the commit hash of this patch into the .git-blame-ignore-revs file.

Thanks. The "fi" ligature was probably an artifact from copy/pasting from the PDF article.
If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

share/man/man4/capsicum.4
75

There's a smart quote here as well.

If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

Sure. One of the warnings is: STYLE: referenced manual not found: Xr pdwait4 2. As I can see, pdwait(2) syscall is about to be introduced by https://reviews.freebsd.org/D54592 soon. So shall we keep the reference to pdwait4(2) (but change it to pdwait(2))?

If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

Sure. One of the warnings is: STYLE: referenced manual not found: Xr pdwait4 2. As I can see, pdwait(2) syscall is about to be introduced by https://reviews.freebsd.org/D54592 soon. So shall we keep the reference to pdwait4(2) (but change it to pdwait(2))?

We've never had pdwait4. There are other references to pdwait4(2) in related man pages, I would prefer to remove all of them separately.

One thing I’d like to ask is that the commit be retitled to something along the lines of: capsicum.4: Replace 'fi' ligature and smart quotation mark. The reason I came across this review is that I recently imported Unicode 17 and initially thought there was a bug in one of the characters.

If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

Sure. One of the warnings is: STYLE: referenced manual not found: Xr pdwait4 2. As I can see, pdwait(2) syscall is about to be introduced by https://reviews.freebsd.org/D54592 soon. So shall we keep the reference to pdwait4(2) (but change it to pdwait(2))?

We've never had pdwait4. There are other references to pdwait4(2) in related man pages, I would prefer to remove all of them separately.

Alright.

One thing I’d like to ask is that the commit be retitled to something along the lines of: capsicum.4: Replace 'fi' ligature and smart quotation mark. The reason I came across this review is that I recently imported Unicode 17 and initially thought there was a bug in one of the characters.

Sure, ok.

But I also have one more question: one of the warnings is also about unexisting .Xr sysctl 2. As I can see, there is no sysctl(2) in FreeBSD, only sysctl(3). But the man pages talks about it in the context of syscalls, so it seems that we can't just change sysctl(2) to sysctl(3) since sysctl(3) is not a syscall. What sould we do about that?

But I also have one more question: one of the warnings is also about unexisting .Xr sysctl 2. As I can see, there is no sysctl(2) in FreeBSD, only sysctl(3). But the man pages talks about it in the context of syscalls, so it seems that we can't just change sysctl(2) to sysctl(3) since sysctl(3) is not a syscall. What sould we do about that?

I would not change it in this revision.

tembun_bk.ru retitled this revision from capsicum.4: Fix Unicode characters to capsicum.4: Replace 'fi' ligature and smart quotation mark.
tembun_bk.ru edited the summary of this revision. (Show Details)

Fix mandoc -T lint warnings:

  • Replace smart quotation mark.
  • Wrap the line to 80 characters.

Also, change the commit title as suggested by @jlduran.

This revision is now accepted and ready to land.Tue, Jan 20, 1:39 AM