While here, wrap the line to 80 characters.
Fixes: c54534e60263 ("capsicum.4: Add some more detail from the Capsicum paper")
Differential D54761
capsicum.4: Replace 'fi' ligature and smart quotation mark Authored by tembun_bk.ru on Sat, Jan 17, 9:27 PM. Tags Referenced Files
Details While here, wrap the line to 80 characters. Fixes: c54534e60263 ("capsicum.4: Add some more detail from the Capsicum paper")
Diff Detail
Event TimelineComment Actions I guess that it would be a good idea to add the commit hash of this patch into the .git-blame-ignore-revs file. Comment Actions Thanks. The "fi" ligature was probably an artifact from copy/pasting from the PDF article.
Comment Actions Sure. One of the warnings is: STYLE: referenced manual not found: Xr pdwait4 2. As I can see, pdwait(2) syscall is about to be introduced by https://reviews.freebsd.org/D54592 soon. So shall we keep the reference to pdwait4(2) (but change it to pdwait(2))? Comment Actions We've never had pdwait4. There are other references to pdwait4(2) in related man pages, I would prefer to remove all of them separately. One thing I’d like to ask is that the commit be retitled to something along the lines of: capsicum.4: Replace 'fi' ligature and smart quotation mark. The reason I came across this review is that I recently imported Unicode 17 and initially thought there was a bug in one of the characters. Comment Actions Alright.
Sure, ok. But I also have one more question: one of the warnings is also about unexisting .Xr sysctl 2. As I can see, there is no sysctl(2) in FreeBSD, only sysctl(3). But the man pages talks about it in the context of syscalls, so it seems that we can't just change sysctl(2) to sysctl(3) since sysctl(3) is not a syscall. What sould we do about that? Comment Actions
I would not change it in this revision. Comment Actions Fix mandoc -T lint warnings:
Also, change the commit title as suggested by @jlduran. | ||||||||||||||||||||||||||||||||||