While here, wrap the line to 80 characters.
Fixes: c54534e60263 ("capsicum.4: Add some more detail from the Capsicum paper")
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I guess that it would be a good idea to add the commit hash of this patch into the .git-blame-ignore-revs file.
Comment Actions
Thanks. The "fi" ligature was probably an artifact from copy/pasting from the PDF article.
If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.
| share/man/man4/capsicum.4 | ||
|---|---|---|
| 75 | There's a smart quote here as well. | |
Comment Actions
Sure. One of the warnings is: STYLE: referenced manual not found: Xr pdwait4 2. As I can see, pdwait(2) syscall is about to be introduced by https://reviews.freebsd.org/D54592 soon. So shall we keep the reference to pdwait4(2) (but change it to pdwait(2))?
Comment Actions
We've never had pdwait4. There are other references to pdwait4(2) in related man pages, I would prefer to remove all of them separately.
One thing I’d like to ask is that the commit be retitled to something along the lines of: capsicum.4: Replace 'fi' ligature and smart quotation mark. The reason I came across this review is that I recently imported Unicode 17 and initially thought there was a bug in one of the characters.
Comment Actions
Alright.
One thing I’d like to ask is that the commit be retitled to something along the lines of: capsicum.4: Replace 'fi' ligature and smart quotation mark. The reason I came across this review is that I recently imported Unicode 17 and initially thought there was a bug in one of the characters.
Sure, ok.
But I also have one more question: one of the warnings is also about unexisting .Xr sysctl 2. As I can see, there is no sysctl(2) in FreeBSD, only sysctl(3). But the man pages talks about it in the context of syscalls, so it seems that we can't just change sysctl(2) to sysctl(3) since sysctl(3) is not a syscall. What sould we do about that?
Comment Actions
But I also have one more question: one of the warnings is also about unexisting .Xr sysctl 2. As I can see, there is no sysctl(2) in FreeBSD, only sysctl(3). But the man pages talks about it in the context of syscalls, so it seems that we can't just change sysctl(2) to sysctl(3) since sysctl(3) is not a syscall. What sould we do about that?
I would not change it in this revision.
Comment Actions
Fix mandoc -T lint warnings:
- Replace smart quotation mark.
- Wrap the line to 80 characters.
Also, change the commit title as suggested by @jlduran.
Comment Actions
But I also have one more question: one of the warnings is also about unexisting .Xr sysctl 2. As I can see, there is no sysctl(2) in FreeBSD, only sysctl(3). But the man pages talks about it in the context of syscalls, so it seems that we can't just change sysctl(2) to sysctl(3) since sysctl(3) is not a syscall. What sould we do about that?
Maybe this:
diff --git a/share/man/man4/capsicum.4 b/share/man/man4/capsicum.4 index 1de8e4531f4f..abdf782c62d2 100644 --- a/share/man/man4/capsicum.4 +++ b/share/man/man4/capsicum.4 @@ -70,10 +70,10 @@ Access to system calls in capability mode is restricted: some system calls requiring global namespace access are unavailable, while others are constrained. For instance, -.Xr sysctl 2 +.Xr sysctl 3 can be used to query process-local information such as address space layout, but also to monitor a system’s network connections. -.Xr sysctl 2 +The sysctl system call is constrained by explicitly marking \(~~60 of over 15000 parameters as permitted in capability mode; all others are denied. .Pp