arm64/iommu: Fix a resource leak in smmu_domain_alloc()
ClosedPublic
Actions

Authored by markj on Mon, Jan 12, 9:16 PM.

Details

Reviewers

br
andrew
manu

Commits

rG4d9eaa04bde6: arm64/iommu: Fix a resource leak in smmu_domain_alloc()
rG6740cccb1eff: arm64/iommu: Fix a resource leak in smmu_domain_alloc()

Summary

We should free the allocated ASID if smmu_init_cd() fails.

Move the allocation of "domain" to simplify the first error path.

Reported by: Kevin Day <kevin@your.org>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jan 12, 9:16 PM

Herald added a reviewer: andrew. · View Herald TranscriptMon, Jan 12, 9:16 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

markj requested review of this revision.Mon, Jan 12, 9:16 PM

Harbormaster completed remote builds in B69838: Diff 169544.Wed, Jan 14, 12:50 AM

br accepted this revision.Thu, Jan 15, 8:36 AM

This revision is now accepted and ready to land.Thu, Jan 15, 8:36 AM

Closed by commit rG6740cccb1eff: arm64/iommu: Fix a resource leak in smmu_domain_alloc() (authored by markj). · Explain WhyThu, Jan 15, 2:21 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG6740cccb1eff: arm64/iommu: Fix a resource leak in smmu_domain_alloc().

markj added a commit: rG4d9eaa04bde6: arm64/iommu: Fix a resource leak in smmu_domain_alloc().Mon, Jan 26, 12:53 AM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

iommu/

smmu.c

5 lines

Diff 169779

View Options

arm64/iommu: Fix a resource leak in smmu_domain_alloc()ClosedPublicActions