linuxkpi: Clean up linux_shmem_file_setup() a bit
ClosedPublic
Actions

Authored by markj on Mon, Jan 12, 6:56 PM.

Details

Reviewers

emaste
bz
brooks

Group Reviewers

linuxkpi
cheri

Commits

rG251662e5abdd: linuxkpi: Clean up linux_shmem_file_setup() a bit

Summary

Free the pointer that was returned by the allocator, instead of the address of the first member. These will be equal in practice, but it's sketchy and possibly won't work on CHERI.
Use an anonymous struct, there's no need to name it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jan 12, 6:56 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMon, Jan 12, 6:56 PM

markj requested review of this revision.Mon, Jan 12, 6:56 PM

Herald added a reviewer: cheri. · View Herald TranscriptMon, Jan 12, 6:56 PM

markj added a parent revision: D54672: linuxkpi: Avoid a potential null pointer dereference in an error path.Mon, Jan 12, 6:56 PM

Harbormaster completed remote builds in B69831: Diff 169535.Wed, Jan 14, 12:50 AM

emaste accepted this revision.Wed, Jan 14, 4:26 PM

This revision is now accepted and ready to land.Wed, Jan 14, 4:26 PM

bz accepted this revision.Wed, Jan 14, 5:02 PM

In practice, this would be fine with default CHERI C, but broken with subobject bounds.

Closed by commit rG251662e5abdd: linuxkpi: Clean up linux_shmem_file_setup() a bit (authored by markj). · Explain WhyThu, Jan 15, 2:20 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG251662e5abdd: linuxkpi: Clean up linux_shmem_file_setup() a bit.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_shmemfs.c

7 lines

Diff 169777

View Options

sys/compat/linuxkpi/common/src/linux_shmemfs.c

linuxkpi: Clean up linux_shmem_file_setup() a bitClosedPublicActions