Page MenuHomeFreeBSD
Differential D54673

linuxkpi: Clean up linux_shmem_file_setup() a bit
ClosedPublic
Actions

Authored by markj on Mon, Jan 12, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 1, 3:25 AM
Unknown Object (File)
Sat, Jan 31, 6:22 AM
Unknown Object (File)
Wed, Jan 28, 1:30 AM
Unknown Object (File)
Mon, Jan 26, 4:48 PM
Unknown Object (File)
Sun, Jan 25, 11:20 AM
Unknown Object (File)
Sun, Jan 25, 6:39 AM
Unknown Object (File)
Sat, Jan 24, 6:00 AM
Unknown Object (File)
Fri, Jan 23, 10:05 PM
View All 21 Files
Subscribers
brooks
emaste
imp

Details

Reviewers
emaste
bz
brooks
Group Reviewers
linuxkpi
cheri
Commits
rGf1e1bfe228e9: linuxkpi: Clean up linux_shmem_file_setup() a bit
rG251662e5abdd: linuxkpi: Clean up linux_shmem_file_setup() a bit
Summary
  • Free the pointer that was returned by the allocator, instead of the address of the first member. These will be equal in practice, but it's sketchy and possibly won't work on CHERI.
  • Use an anonymous struct, there's no need to name it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jan 12, 6:56 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMon, Jan 12, 6:56 PM
markj requested review of this revision.Mon, Jan 12, 6:56 PM
Herald added a reviewer: cheri. · View Herald TranscriptMon, Jan 12, 6:56 PM
markj added a parent revision: D54672: linuxkpi: Avoid a potential null pointer dereference in an error path.Mon, Jan 12, 6:56 PM
Harbormaster completed remote builds in B69831: Diff 169535.Wed, Jan 14, 12:50 AM
emaste accepted this revision.Wed, Jan 14, 4:26 PM
This revision is now accepted and ready to land.Wed, Jan 14, 4:26 PM
bz accepted this revision.Wed, Jan 14, 5:02 PM
brooks accepted this revision.Thu, Jan 15, 11:38 AM
brooks added a subscriber: brooks.

In practice, this would be fine with default CHERI C, but broken with subobject bounds.

Closed by commit rG251662e5abdd: linuxkpi: Clean up linux_shmem_file_setup() a bit (authored by markj). · Explain WhyThu, Jan 15, 2:20 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG251662e5abdd: linuxkpi: Clean up linux_shmem_file_setup() a bit.
markj added a commit: rGf1e1bfe228e9: linuxkpi: Clean up linux_shmem_file_setup() a bit.Mon, Jan 26, 12:53 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
7 lines

Diff 169777

View Options

sys/compat/linuxkpi/common/src/linux_shmemfs.c

Loading...