Differential D54599

libc/csu: Pass HWCAP flags to ifunc resolver functions
ClosedPublic
Actions

Authored by sarah.walker2_arm.com on Thu, Jan 8, 10:52 AM.

Tags

None

Referenced Files

	F142010035: D54599.id169400.diff
	Wed, Jan 14, 9:16 PM

	Unknown Object (File)
	Tue, Jan 13, 9:54 AM

	Unknown Object (File)
	Mon, Jan 12, 7:03 PM

	Unknown Object (File)
	Mon, Jan 12, 1:00 AM

	Unknown Object (File)
	Sat, Jan 10, 3:07 PM

	Unknown Object (File)
	Sat, Jan 10, 8:09 AM

	Unknown Object (File)
	Sat, Jan 10, 7:23 AM

	Unknown Object (File)
	Sat, Jan 10, 4:44 AM

View All 13 Files

Subscribers

Details

Reviewers

Commits

rG5eec3531204b: libc/csu: Pass HWCAP flags to ifunc resolver functions

Summary

Function arguments are based on Section 9.4.1 "GNU C Library IFUNC interface"
from "System V ABI for the Arm 64-bit Architecture (AArch64)", 2025Q1.
(https://github.com/ARM-software/abi-aa/releases/download/2025Q1/sysvabi64.pdf)

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sarah.walker2_arm.com created this revision.Thu, Jan 8, 10:52 AM

Herald added a reviewer: andrew. · View Herald TranscriptThu, Jan 8, 10:52 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

sarah.walker2_arm.com requested review of this revision.Thu, Jan 8, 10:52 AM

Harbormaster completed remote builds in B69714: Diff 169314.Thu, Jan 8, 10:52 AM

sarah.walker2_arm.com mentioned this in D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.Thu, Jan 8, 12:06 PM

andrew added inline comments.Thu, Jan 8, 2:36 PM

lib/libc/csu/aarch64/reloc.c
63

Address style issues.

Harbormaster completed remote builds in B69761: Diff 169400.Fri, Jan 9, 4:05 PM

andrew added inline comments.Fri, Jan 9, 5:34 PM

lib/libc/csu/aarch64/reloc.c
63	The second arg is no longer const in the other places we define the function pointer type. (not sure if it should be or not as long as it's consistent)

Make ifunc_arg argument const.

Harbormaster completed remote builds in B69818: Diff 169510.Mon, Jan 12, 9:43 AM

andrew accepted this revision.Mon, Jan 12, 10:55 AM

This revision is now accepted and ready to land.Mon, Jan 12, 10:55 AM

Closed by commit rG5eec3531204b: libc/csu: Pass HWCAP flags to ifunc resolver functions (authored by sarah.walker2_arm.com, committed by andrew). · Explain WhyWed, Jan 14, 12:54 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG5eec3531204b: libc/csu: Pass HWCAP flags to ifunc resolver functions.

Revision Contents
Changeset List

Path

Size

lib/

libc/

csu/

aarch64/

31 lines

Diff 169592

lib/libc/csu/aarch64/reloc.c

Loading...