Differential D54502

linuxkpi: Add `radix_tree_deref_slot()`
ClosedPublic
Actions

Authored by dumbbell on Sun, Jan 4, 10:31 AM.

Details

Reviewers

Group Reviewers

linuxkpi

Commits

rG4c89b333808a: linuxkpi: Add `radix_tree_deref_slot()`

Summary

We don't do reference counting, therefore this is a no-op.

The amdgpu DRM driver started to use it in Linux 6.10.

This is part of the update of DRM drivers to Linux 6.10.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dumbbell created this revision.Sun, Jan 4, 10:31 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptSun, Jan 4, 10:31 AM

dumbbell requested review of this revision.Sun, Jan 4, 10:31 AM

Technically this is not a no-op as you do a *-operation.

Looking at radix_tree_lookup() it seems we also do not provide pointer stability, so this should be fine within our implementation at least.

This revision is now accepted and ready to land.Sun, Jan 4, 9:48 PM

Closed by commit rG4c89b333808a: linuxkpi: Add `radix_tree_deref_slot()` (authored by dumbbell). · Explain WhyMon, Jan 5, 8:10 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG4c89b333808a: linuxkpi: Add `radix_tree_deref_slot()`.

In D54502#1245389, @bz wrote:

Technically this is not a no-op as you do a *-operation.

Good catch, I modified the commit message.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

radix-tree.h

6 lines

Diff 169118

View Options

sys/compat/linuxkpi/common/include/linux/radix-tree.h

linuxkpi: Add `radix_tree_deref_slot()`ClosedPublicActions