pf: Fix error handling in pf_handle_get_tstats()
ClosedPublic
Actions

Authored by markj on Dec 5 2025, 9:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 16, 11:43 PM

	Unknown Object (File)
	Sat, May 16, 11:43 PM

	Unknown Object (File)
	Sat, May 16, 11:43 PM

	Unknown Object (File)
	Apr 20 2026, 10:09 PM

	Unknown Object (File)
	Apr 15 2026, 12:43 PM

	Unknown Object (File)
	Apr 15 2026, 12:54 AM

	Unknown Object (File)
	Apr 14 2026, 11:36 PM

	Unknown Object (File)
	Apr 6 2026, 3:41 PM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

Commits

rG1910f18b00fc: pf: Fix error handling in pf_handle_get_tstats()
rG0f0662c6b4cc: pf: Fix error handling in pf_handle_get_tstats()

Summary

pfr_table_count() can return an error.
We must check for failure from mallocarray(M_NOWAIT).

Fixes: 9e8d2962aad3 ("pf: convert DIOCRGETTSTATS to netlink")
Reported by: Kevin Day <kevin@your.org>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 5 2025, 9:45 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptDec 5 2025, 9:45 PM

markj requested review of this revision.Dec 5 2025, 9:45 PM

Harbormaster completed remote builds in B69082: Diff 167609.Dec 5 2025, 9:45 PM

kp accepted this revision.Dec 8 2025, 12:04 PM

This revision is now accepted and ready to land.Dec 8 2025, 12:04 PM

Closed by commit rG0f0662c6b4cc: pf: Fix error handling in pf_handle_get_tstats() (authored by markj). · Explain WhyDec 8 2025, 2:12 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0f0662c6b4cc: pf: Fix error handling in pf_handle_get_tstats().

markj added a commit: rG1910f18b00fc: pf: Fix error handling in pf_handle_get_tstats().Dec 15 2025, 2:18 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_nl.c

10 lines

Diff 167696

View Options

pf: Fix error handling in pf_handle_get_tstats()ClosedPublicActions