bsdinstall: remove unused file/build code
Needs ReviewPublic
Actions

Authored by ifreund_freebsdfoundation.org on Tue, Dec 2, 4:29 PM.

Details

Reviewers

emaste
cperciva

Summary

This file and the supporting build code has been unused since
commit bdfc223c7a64369ed133a179c40067435a9f2cb3 stopped installing
FreeBSD-base.conf.

The FreeBSD-base repo is now configured in /etc/pkg/FreeBSD.conf.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68999
Build 65882: arc lint + arc unit

Event Timeline

ifreund_freebsdfoundation.org created this revision.Tue, Dec 2, 4:29 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptTue, Dec 2, 4:29 PM

ifreund_freebsdfoundation.org requested review of this revision.Tue, Dec 2, 4:29 PM

Harbormaster completed remote builds in B68999: Diff 167435.Tue, Dec 2, 4:29 PM

We still want this for the install images.

Oh, I see now that I assumed bsdinstall now uses /etc/pkg/FreeBSD.conf and overlooked the repos_dir = "/usr/share/bsdinstall/" line.

Why do we not use /etc/pkg/FreeBSD.conf for bsdinstall? I'm not seeing a case where the configuration for the FreeBSD-base repository there is different and it would be nice to get rid of the duplication if it is infact unnecessary.

In D54035#1234772, @ifreund_freebsdfoundation.org wrote:

Oh, I see now that I assumed bsdinstall now uses /etc/pkg/FreeBSD.conf and overlooked the repos_dir = "/usr/share/bsdinstall/" line.

Why do we not use /etc/pkg/FreeBSD.conf for bsdinstall? I'm not seeing a case where the configuration for the FreeBSD-base repository there is different and it would be nice to get rid of the duplication if it is infact unnecessary.

It's different for BETAs and RCs. The bsdinstall configuration points at e.g. base_release_0_rc4 while /etc/pkg/FreeBSD.conf points at base_release_0. This ensures that the 15.0-RC4 installer installs 15.0-RC4, but after installation people can upgrade from there to 15.0-RELEASE.