Page MenuHomeFreeBSD

bsdinstall: remove unused file/build code
Needs ReviewPublic

Authored by ifreund_freebsdfoundation.org on Tue, Dec 2, 4:29 PM.
Tags
None
Referenced Files
F140544850: D54035.diff
Thu, Dec 25, 2:40 AM
Unknown Object (File)
Thu, Dec 18, 7:47 AM
Unknown Object (File)
Wed, Dec 17, 12:36 PM
Unknown Object (File)
Thu, Dec 4, 10:09 AM
Unknown Object (File)
Thu, Dec 4, 10:09 AM
Subscribers

Details

Reviewers
emaste
cperciva
Summary

This file and the supporting build code has been unused since
commit bdfc223c7a64369ed133a179c40067435a9f2cb3 stopped installing
FreeBSD-base.conf.

The FreeBSD-base repo is now configured in /etc/pkg/FreeBSD.conf.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68999
Build 65882: arc lint + arc unit

Event Timeline

We still want this for the install images.

Oh, I see now that I assumed bsdinstall now uses /etc/pkg/FreeBSD.conf and overlooked the repos_dir = "/usr/share/bsdinstall/" line.

Why do we not use /etc/pkg/FreeBSD.conf for bsdinstall? I'm not seeing a case where the configuration for the FreeBSD-base repository there is different and it would be nice to get rid of the duplication if it is infact unnecessary.

Oh, I see now that I assumed bsdinstall now uses /etc/pkg/FreeBSD.conf and overlooked the repos_dir = "/usr/share/bsdinstall/" line.

Why do we not use /etc/pkg/FreeBSD.conf for bsdinstall? I'm not seeing a case where the configuration for the FreeBSD-base repository there is different and it would be nice to get rid of the duplication if it is infact unnecessary.

It's different for BETAs and RCs. The bsdinstall configuration points at e.g. base_release_0_rc4 while /etc/pkg/FreeBSD.conf points at base_release_0. This ensures that the 15.0-RC4 installer installs 15.0-RC4, but after installation people can upgrade from there to 15.0-RELEASE.