Page MenuHomeFreeBSD
Differential D5394

Enable GICv3 system register interface
ClosedPublic
Actions

Authored by mst_semihalf.com on Feb 22 2016, 4:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 6 2024, 12:48 PM
Unknown Object (File)
Oct 20 2024, 6:21 AM
Unknown Object (File)
Oct 5 2024, 10:37 AM
Unknown Object (File)
Sep 23 2024, 5:14 AM
Unknown Object (File)
Sep 20 2024, 1:59 AM
Unknown Object (File)
Sep 19 2024, 11:37 AM
Unknown Object (File)
Sep 18 2024, 11:03 PM
Unknown Object (File)
Sep 16 2024, 3:51 PM
View All 47 Files
Subscribers
emaste
arm64

Details

Reviewers
wma
andrew
imp
Commits
rS296256: Enable SRE_EL2 on ARM64
Summary

Set SRE bit in ICC_SRE_EL2 register.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mst_semihalf.com updated this revision to Diff 13610.Feb 22 2016, 4:09 PM
mst_semihalf.com retitled this revision from to Enable GICv3 system register interface.
mst_semihalf.com updated this object.
mst_semihalf.com edited the test plan for this revision. (Show Details)
mst_semihalf.com added reviewers: andrew, imp, wma.
mst_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
mst_semihalf.com added a subscriber: arm64.
Herald added a subscriber: emaste. · View Herald TranscriptFeb 22 2016, 4:09 PM
emaste added inline comments.Feb 22 2016, 4:14 PM
sys/arm64/arm64/locore.S
268 ↗(On Diff #13610)

Any reason these shouldn't be combined into one orr?

mst_semihalf.com added a child revision: D5395: Add initial support for Alpine V2.Feb 22 2016, 4:32 PM
mst_semihalf.com added inline comments.Feb 22 2016, 6:10 PM
sys/arm64/arm64/locore.S
268 ↗(On Diff #13610)

As it turns out, ARMv8 has special requirements regarding logical immediates and this particular combination of bits does not qualify.

wma accepted this revision.Feb 23 2016, 7:39 AM
wma edited edge metadata.

Just tested on ThunderX and is working.

This revision is now accepted and ready to land.Feb 23 2016, 7:39 AM
andrew edited edge metadata.Feb 23 2016, 9:23 AM

For what purpose is this patch? I can see it enables the system register interface, but why does it need to be enabled?

mst_semihalf.com added a comment.Feb 23 2016, 1:41 PM
In D5394#115111, @andrew wrote:

For what purpose is this patch? I can see it enables the system register interface, but why does it need to be enabled?

It is always needed for ARM64 as we use the system registers, not memory-mapped ones. I guess in case of ThunderX the bit was already set by the bootloader. In the case of Alpine V2 it was not, which resulted in an error in GIC attach.

Closed by commit rS296256: Enable SRE_EL2 on ARM64 (authored by wma). · Explain WhyMar 1 2016, 8:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
1 line
include/
1 line

Diff 13922

View Options

head/sys/arm64/arm64/locore.S

Loading...
View Options

head/sys/arm64/include/armreg.h

Loading...