Fintek F81232 USB to serial driver

[db]

Summary

• Fintek f81232 usb to serial driver

Test Plan

I have only tested it on a Protecli box which came with a Fintek
USB to serial cable.

[adrian]

looks good to me but the lack of mutexes anywhere is suspicious. ;-)

[thj]

In D53893#1231126, @adrian wrote:

looks good to me but the lack of mutexes anywhere is suspicious. ;-)

There is an sc_mtx created and used in attach. ucom handles locking for serial devices with their mutex.

sys/dev/usb/serial/ufintek.c

2

I think we need an spdx identifier for new files. We don't need the full copyright text, but that call is up to you.

29

Do we need this comment?

289

368

Can you combine these lines, it makes grepping for the error message possible

653

Should this be a device_printf? I'm not sure what the ZZZ is for

sys/modules/ufintek/Makefile

2

Same spdx comment as above

[thj]

This looks great to me, some small nits for which I have made comments.

Can you either remove the commented out code lines in the driver, or add additional context so we know why they are gone/what they are for when we eventually have to look in n years?

[db]

sys/dev/usb/serial/ufintek.c

2

I think we need an spdx identifier for new files. We don't need the full copyright text, but that call is up to you.

Good idea. Done.

29

Agreed and removed.

289

moved not mored or moored.

368

Done

653

Eeek inadvertently left in a debug message. I often use ZZZ for these.

sys/modules/ufintek/Makefile

2

Fixed. Also fixed a C'ism that crept into the Makefile.

[db]

Updating D53893: Fintek F81232 USB to serial driver

Addressing reviewers changes

[thj]

sys/dev/usb/serial/ufintek.c

742

These commented out lines are still here, can you add an explanation for why they are here, but commented out?

[db]

Removing unecessary comment lines

These lines were an experiment but not necessary.