krb5: Use sh to run mk_cmds
ClosedPublic
Actions

Authored by markj on Fri, Nov 21, 5:58 PM.

Details

Reviewers

des
ivy
cy

Group Reviewers

krb5

Commits

rG0db8e36b2baa: krb5: Use sh to run mk_cmds
rG673924122470: krb5: Use sh to run mk_cmds

Summary

This is a bandaid, we shouldn't have these explicit targets at all. I
think what's happening in the PR is that etcupdate is running "make
installconfig", which is triggering rebuilds of unrelated things. Using
sh explicitly works around that.

PR: 291043

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68787
Build 65670: arc lint + arc unit

Event Timeline

markj created this revision.Fri, Nov 21, 5:58 PM

Herald added subscribers: ivy, imp. · View Herald TranscriptFri, Nov 21, 5:58 PM

markj requested review of this revision.Fri, Nov 21, 5:58 PM

Harbormaster completed remote builds in B68787: Diff 166919.Fri, Nov 21, 5:58 PM

the problem reported in the PR is:

make[4]: exec(./mk_cmds): Permission denied

i don't see how this change can fix it. why isn't mk_cmds executable? the target clearly runs chmod 755 on it.

also from the PR:

===> krb5/util/ss (obj,all,install)
[Creating objdir /var/db/etcupdate/etcupdate-3aVqeOA/usr/obj/usr/src/amd64.amd64/tmp/obj-tools/krb5/util/ss...]

the reporter has /var/db mounted noexec, which explains the problem. but is this supported or expected behaviour?

Yes, having a separate noexec /var/db is common practice and should be supported, and the real bug is that mk_cmds is not needed by installconfig and should not be run at all. This is just a workaround to unbreak etcupdate until the Makefiles can be cleaned up. We might additionally look into having etcupdate use a different MAKEOBJDIRPREFIX.