Page MenuHomeFreeBSD

sound: Retire snd_mixer->busy
Needs ReviewPublic

Authored by christos on Fri, Nov 21, 5:05 PM.
Tags
None
Referenced Files
F137288936: D53859.diff
Sat, Nov 22, 2:30 AM
F137284233: D53859.diff
Sat, Nov 22, 1:24 AM
F137283833: D53859.id166912.diff
Sat, Nov 22, 1:19 AM
F137283822: D53859.id.diff
Sat, Nov 22, 1:19 AM
Subscribers

Details

Reviewers
markj
emaste
kib
Summary

Does not really serve any real purpose. It gets set on mixer_open() and
unset on mixer_close(), so it essentially tells us whether the mixer is
open or not.

mixer_close() uses it to return EBADF in case the mixer is not busied,
as in, the mixer has not been open()'d yet. This is redundant. The other
place where this is used is to decide whether to serve an ioctl issued
by userland, in which case it won't if, again, the mixer has not been
busied (i.e., opened). Again, seems redundant.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68785
Build 65668: arc lint + arc unit