Paths

Table of Contentst

Differential D53859

sound: Retire snd_mixer->busy
ClosedPublic
Actions

Authored by christos on Nov 21 2025, 5:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 17, 11:42 AM

	Unknown Object (File)
	Sun, Aug 9, 1:20 AM

	Unknown Object (File)
	Sat, Aug 8, 5:42 PM

	Unknown Object (File)
	Wed, Aug 5, 6:05 AM

	Unknown Object (File)
	Wed, Aug 5, 2:41 AM

	Unknown Object (File)
	Tue, Aug 4, 4:38 AM

	Unknown Object (File)
	Mon, Aug 3, 9:18 AM

	Unknown Object (File)
	Sat, Aug 1, 11:07 AM

View All 69 Files

Subscribers

Details

Reviewers

markj
emaste
kib

Commits

rG26365bf2516f: sound: Retire snd_mixer->busy
rGe5d50a679aa1: sound: Retire snd_mixer->busy

Summary

Does not really serve any real purpose. It gets set on mixer_open() and
unset on mixer_close(), so it essentially tells us whether the mixer is
open or not.

mixer_close() uses it to return EBADF in case the mixer is not busied,
as in, the mixer has not been open()'d yet. This is redundant. The other
place where this is used is to decide whether to serve an ioctl issued
by userland, in which case it won't if, again, the mixer has not been
busied (i.e., opened). Again, seems redundant.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Nov 21 2025, 5:05 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 21 2025, 5:05 PM

christos requested review of this revision.Nov 21 2025, 5:05 PM

Harbormaster completed remote builds in B68785: Diff 166912.Nov 21 2025, 5:05 PM

markj accepted this revision.Nov 28 2025, 2:03 PM

markj added inline comments.

sys/dev/sound/pci/es137x.c
1543	Was the busy state just getting leaked here?

This revision is now accepted and ready to land.Nov 28 2025, 2:03 PM

christos added inline comments.Nov 28 2025, 2:31 PM

sys/dev/sound/pci/es137x.c
1543	I don't think so. The busy state was set in `mixer_open()` (i.e., open(2) for `/dev/mixer`), and cleared in `mixer_close()`.

Closed by commit rGe5d50a679aa1: sound: Retire snd_mixer->busy (authored by christos). · Explain WhyNov 28 2025, 2:36 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGe5d50a679aa1: sound: Retire snd_mixer->busy.

christos added a commit: rG26365bf2516f: sound: Retire snd_mixer->busy.Dec 6 2025, 1:36 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pci/

4 lines

pcm/

2 lines

30 lines

Diff 167239

sys/dev/sound/pci/es137x.c

Loading...

sys/dev/sound/pcm/mixer.h

Loading...

sys/dev/sound/pcm/mixer.c

Loading...