sound: Clean up midi/ includes
Needs ReviewPublic
Actions

Authored by christos on Thu, Nov 20, 2:00 PM.

Details

Reviewers

markj
emaste
imp

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68764
Build 65647: arc lint + arc unit

Event Timeline

christos requested review of this revision.Thu, Nov 20, 2:00 PM

christos created this revision.

Harbormaster completed remote builds in B68764: Diff 166846.Thu, Nov 20, 2:00 PM

emaste added inline comments.Thu, Nov 20, 4:06 PM

sys/dev/sound/midi/midi.c

style(9) calls for sys/types.h first

Kernel include files (sys/*.h) come first.  If either <sys/types.h> or
<sys/param.h> is needed, include it before other include files.
(<sys/param.h> includes <sys/types.h>; do not include both.) Next,
include <sys/systm.h>, if needed.  The remaining kernel headers should be
sorted alphabetically.

sys/dev/sound/midi/midi.h

Do we not want this for uint8_t?