unix: Fix handling of listening sockets during garbage collection
ClosedPublic
Actions

Authored by markj on Thu, Nov 13, 7:42 PM.

Details

Reviewers

Commits

rGf7c3aa281504: unix: Fix handling of listening sockets during garbage collection
rG9d9fa9a2c22f: unix: Fix handling of listening sockets during garbage collection

Summary

socantrcvmore() and unp_dispose() assume that the socket's socket
buffers are initialized, which isn't the case for listening sockets.

Reported by: syzbot+a62883292a5c257703be@syzkaller.appspotmail.com

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Thu, Nov 13, 7:42 PM

Herald added subscribers: olce, imp. · View Herald TranscriptThu, Nov 13, 7:42 PM

markj requested review of this revision.Thu, Nov 13, 7:42 PM

Harbormaster completed remote builds in B68617: Diff 166385.Thu, Nov 13, 7:42 PM

glebius accepted this revision.Thu, Nov 13, 10:39 PM

This revision is now accepted and ready to land.Thu, Nov 13, 10:39 PM

Closed by commit rG9d9fa9a2c22f: unix: Fix handling of listening sockets during garbage collection (authored by markj). · Explain WhyFri, Nov 14, 12:46 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG9d9fa9a2c22f: unix: Fix handling of listening sockets during garbage collection.

markj added a commit: rGf7c3aa281504: unix: Fix handling of listening sockets during garbage collection.Fri, Nov 21, 2:25 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_usrreq.c

10 lines

tests/

sys/

kern/

unix_passfd_test.c

29 lines

Diff 166401

View Options

sys/kern/uipc_usrreq.c