Page MenuHomeFreeBSD
Differential D53710

ministat: Clean up usage message, manual page, and chameleon
ClosedPublic
Actions

Authored by 0mp on Nov 12 2025, 3:09 PM.
Tags
None
Referenced Files
F156569465: D53710.diff
Thu, May 14, 6:08 PM
Unknown Object (File)
Thu, May 14, 10:16 AM
Unknown Object (File)
Thu, May 14, 3:32 AM
Unknown Object (File)
Thu, May 14, 3:32 AM
Unknown Object (File)
Wed, May 13, 5:11 PM
Unknown Object (File)
Mon, May 11, 4:06 PM
Unknown Object (File)
Mon, May 11, 4:05 PM
Unknown Object (File)
Mon, May 11, 11:01 AM
View All 74 Files
Subscribers
bcr
imp
pauamma_gundo.com
ziaee

Details

Reviewers
ziaee
bcr
Group Reviewers
manpages
Commits
rGd01fd1a51fd4: ministat: Clean up usage message, manual page, and chameleon
rGe69c36339eba: ministat: Clean up usage message, manual page, and chameleon
rG9d17b61b2fd2: ministat: Clean up usage message, manual page, and chameleon
Summary

In the manual page:

  • Fix synopsis and use better argument names
  • Improve description of flags.
  • In EXAMPLES, list the contents of iguana and chameleon files.
  • Use Rs to reference The Cartoon Guide to Statistics
  • Fix misc indentation and style issues

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Nov 12 2025, 3:09 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptNov 12 2025, 3:09 PM
0mp requested review of this revision.Nov 12 2025, 3:09 PM
Harbormaster completed remote builds in B68573: Diff 166300.Nov 12 2025, 3:09 PM
0mp added a reviewer: manpages.Nov 12 2025, 3:13 PM
ziaee accepted this revision.Nov 12 2025, 3:40 PM

You should tag SPDX too while going this far.

This revision is now accepted and ready to land.Nov 12 2025, 3:40 PM
bcr added a subscriber: bcr.Nov 12 2025, 3:42 PM

Minor fix with suggestion which of the two to use.

usr.bin/ministat/ministat.1
87

s/The each/Each/

or

s/The each dataset/Each dataset/

0mp updated this revision to Diff 166306.Nov 12 2025, 4:28 PM
  • s/The each/each/
  • Tag SPDX
This revision now requires review to proceed.Nov 12 2025, 4:28 PM
Harbormaster completed remote builds in B68575: Diff 166306.Nov 12 2025, 4:28 PM
bcr accepted this revision.Nov 12 2025, 4:39 PM

It's OK now from my side. Thanks for the followup fix and the work itself!

This revision is now accepted and ready to land.Nov 12 2025, 4:39 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Nov 13 2025, 2:59 AM
pauamma_gundo.com added inline comments.
usr.bin/ministat/ministat.1
87

Spell consistently with line 133.

0mp added inline comments.Nov 13 2025, 10:29 AM
usr.bin/ministat/ministat.1
87

Thanks!

Closed by commit rG9d17b61b2fd2: ministat: Clean up usage message, manual page, and chameleon (authored by 0mp). · Explain WhyNov 13 2025, 10:29 AM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rG9d17b61b2fd2: ministat: Clean up usage message, manual page, and chameleon.
0mp added a commit: rGe69c36339eba: ministat: Clean up usage message, manual page, and chameleon.Dec 15 2025, 2:43 PM
0mp added a commit: rGd01fd1a51fd4: ministat: Clean up usage message, manual page, and chameleon.

Revision Contents
Changeset List

PathSize
usr.bin/
ministat/
2 lines
146 lines
2 lines

Diff 166348

View Options

usr.bin/ministat/chameleon

Loading...
View Options

usr.bin/ministat/ministat.1

Loading...
View Options

usr.bin/ministat/ministat.c

Loading...