Page MenuHomeFreeBSD
Differential D53710

ministat: Clean up usage message, manual page, and chameleon
ClosedPublic
Actions

Authored by 0mp on Wed, Nov 12, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 13, 3:56 AM
Unknown Object (File)
Thu, Nov 13, 12:31 AM
Unknown Object (File)
Wed, Nov 12, 10:07 PM
Unknown Object (File)
Wed, Nov 12, 9:28 PM
Unknown Object (File)
Wed, Nov 12, 8:05 PM
Unknown Object (File)
Wed, Nov 12, 8:05 PM
Unknown Object (File)
Wed, Nov 12, 8:05 PM
Unknown Object (File)
Wed, Nov 12, 7:47 PM
Subscribers
bcr
imp
pauamma_gundo.com
ziaee

Details

Reviewers
ziaee
bcr
Group Reviewers
manpages
Commits
rG9d17b61b2fd2: ministat: Clean up usage message, manual page, and chameleon
Summary

In the manual page:

  • Fix synopsis and use better argument names
  • Improve description of flags.
  • In EXAMPLES, list the contents of iguana and chameleon files.
  • Use Rs to reference The Cartoon Guide to Statistics
  • Fix misc indentation and style issues

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Wed, Nov 12, 3:09 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptWed, Nov 12, 3:09 PM
0mp requested review of this revision.Wed, Nov 12, 3:09 PM
Harbormaster completed remote builds in B68573: Diff 166300.Wed, Nov 12, 3:09 PM
0mp added a reviewer: manpages.Wed, Nov 12, 3:13 PM
ziaee accepted this revision.Wed, Nov 12, 3:40 PM

You should tag SPDX too while going this far.

This revision is now accepted and ready to land.Wed, Nov 12, 3:40 PM
bcr added a subscriber: bcr.Wed, Nov 12, 3:42 PM

Minor fix with suggestion which of the two to use.

usr.bin/ministat/ministat.1
87

s/The each/Each/

or

s/The each dataset/Each dataset/

0mp updated this revision to Diff 166306.Wed, Nov 12, 4:28 PM
  • s/The each/each/
  • Tag SPDX
This revision now requires review to proceed.Wed, Nov 12, 4:28 PM
Harbormaster completed remote builds in B68575: Diff 166306.Wed, Nov 12, 4:28 PM
bcr accepted this revision.Wed, Nov 12, 4:39 PM

It's OK now from my side. Thanks for the followup fix and the work itself!

This revision is now accepted and ready to land.Wed, Nov 12, 4:39 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Thu, Nov 13, 2:59 AM
pauamma_gundo.com added inline comments.
usr.bin/ministat/ministat.1
87

Spell consistently with line 133.

0mp added inline comments.Thu, Nov 13, 10:29 AM
usr.bin/ministat/ministat.1
87

Thanks!

Closed by commit rG9d17b61b2fd2: ministat: Clean up usage message, manual page, and chameleon (authored by 0mp). · Explain WhyThu, Nov 13, 10:29 AM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rG9d17b61b2fd2: ministat: Clean up usage message, manual page, and chameleon.

Revision Contents
Changeset List

PathSize
usr.bin/
ministat/
2 lines
146 lines
2 lines

Diff 166348

View Options

usr.bin/ministat/chameleon

Loading...
View Options

usr.bin/ministat/ministat.1

Loading...
View Options

usr.bin/ministat/ministat.c

Loading...