arm64: Fix calculating kernel size for preload metadata
ClosedPublic
Actions

Authored by jhb on Tue, Nov 11, 8:11 PM.

Details

Reviewers

andrew
manu

Group Reviewers

cheri

Commits

rG587490dabc64: arm64: Fix calculating kernel size for preload metadata

Summary

Cast &end to vm_offset_t before subtracting VM_MIN_KERNEL_ADDRESS to
ensure the resulting size is correct for PRELOAD_PUSH_VALUE.
Previously the correct size was effectively divided by sizeof(void *).

Obtained from: CheriBSD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Tue, Nov 11, 8:11 PM

Herald added a reviewer: manu. · View Herald TranscriptTue, Nov 11, 8:11 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

jhb requested review of this revision.Tue, Nov 11, 8:11 PM

Herald added a reviewer: cheri. · View Herald TranscriptTue, Nov 11, 8:11 PM

Harbormaster completed remote builds in B68557: Diff 166265.Tue, Nov 11, 8:11 PM

jhb added a child revision: D53700: sys: Declare 'end' as an extern char so that &end is a char *.Tue, Nov 11, 8:13 PM

andrew accepted this revision.Thu, Nov 13, 1:52 PM

This revision is now accepted and ready to land.Thu, Nov 13, 1:52 PM

Closed by commit rG587490dabc64: arm64: Fix calculating kernel size for preload metadata (authored by Hesham Almatary <Hesham.Almatary@cl.cam.ac.uk>, committed by jhb). · Explain WhyThu, Nov 13, 2:58 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG587490dabc64: arm64: Fix calculating kernel size for preload metadata.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

machdep_boot.c

3 lines

Diff 166365

View Options

sys/arm64/arm64/machdep_boot.c

arm64: Fix calculating kernel size for preload metadataClosedPublicActions