Fix an off-by-one error, d_unit starts at 0.

[andrew]

Summary

This fixes netbooting on ThunderX. I haven't tested it anywhere else.

[smh]

sys/boot/efi/libefi/efinet.c

104

Its very hard for someone to make this mistake, so even though this seems right, it would be good understand why it was like this.

314

This reverts r295210 which will cause an issue.

[andrew]

sys/boot/efi/libefi/efinet.c

104

It was added in rS277943. Based on the commit message I still think it's wrong.

314

In the report that led to rS295210 there was only an issue on interface 1 and 2, not interface 0. I suspect the above will fix the issue. The reported is listed as a reviewer on this patch so it can be tested before being committed.

From my reading of the grub efi network driver code It looks like it depends on the exclusive flag so I would expect it to just be an issue where we were trying to use the wrong handle.

[manu_bidouilliste.com]

This current diff doesn't change netbooting for me, it's even worse because as it can't open the network device in exclusive mode it cannot netboot.
Andrew sent me this patch to test instead : http://www.pastebin.ca/3379018
This works for netbooting my HP laptop and definitly increase the speed.

[emaste]

sys/boot/efi/libefi/efinet.c

104

Indeed, PR 202097 reports that rS277943 broke PXE booting.

[emaste]

@andrew has an updated patch in progress

[andrew]

Not needed, @jhb fixed this in rS300810