Page MenuHomeFreeBSD

sound: Define SNDBUF_F_MANAGED as 0x00000001
AcceptedPublic

Authored by christos on Sat, Nov 1, 5:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 3, 5:28 AM
Unknown Object (File)
Mon, Nov 3, 5:27 AM
Unknown Object (File)
Mon, Nov 3, 1:34 AM
Unknown Object (File)
Sun, Nov 2, 3:54 PM
Unknown Object (File)
Sun, Nov 2, 5:40 AM
Unknown Object (File)
Sun, Nov 2, 5:39 AM
Unknown Object (File)
Sun, Nov 2, 5:37 AM
Unknown Object (File)
Sun, Nov 2, 2:01 AM
Subscribers

Details

Reviewers
emaste
markj
Summary

It's the only flag anyway.

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68332
Build 65215: arc lint + arc unit

Event Timeline

The other constants were removed in the refactoring in e4e61333ffa4e90360de2dd1e4e0146f7cbf0afb

-#define        SNDBUF_F_DMA            0x00000001
-#define        SNDBUF_F_XRUN           0x00000002
-#define        SNDBUF_F_RUNNING        0x00000004

The other constants were removed in the refactoring in e4e61333ffa4e90360de2dd1e4e0146f7cbf0afb

-#define        SNDBUF_F_DMA            0x00000001
-#define        SNDBUF_F_XRUN           0x00000002
-#define        SNDBUF_F_RUNNING        0x00000004

So it's better to leave it as is? Not sure there is good reason to do so, these are internal anyway.

So it's better to leave it as is? Not sure there is good reason to do so, these are internal anyway.

Oops, I had another comment that I deleted accidentally before I submitted. I was just wondering if there's any chance this will be used in an out-of-tree module, or it's entirely internal to the snd infrastructure.

Anyhow I think it doesn't really matter if flags 1/2/4 are unused but I won't object to changing this if it has no external use/visibility.

This revision is now accepted and ready to land.Sat, Nov 1, 10:57 PM