sound: Define SNDBUF_F_MANAGED as 0x00000001
ClosedPublic
Actions

Authored by christos on Nov 1 2025, 5:18 PM.

Details

Reviewers

emaste
markj

Commits

rG7ac082ff1ad9: sound: Define SNDBUF_F_MANAGED as 0x00000001
rGd159b023de52: sound: Define SNDBUF_F_MANAGED as 0x00000001

Summary

It's the only flag anyway.

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Nov 1 2025, 5:18 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2025, 5:18 PM

christos requested review of this revision.Nov 1 2025, 5:18 PM

Harbormaster completed remote builds in B68332: Diff 165642.Nov 1 2025, 5:18 PM

christos added a parent revision: D53520: sound: Re-arrange sndbuf_create() arguments.Nov 1 2025, 5:19 PM

christos added a child revision: D53522: sound: Retire unused sndbuf_dump().

The other constants were removed in the refactoring in e4e61333ffa4e90360de2dd1e4e0146f7cbf0afb

-#define        SNDBUF_F_DMA            0x00000001
-#define        SNDBUF_F_XRUN           0x00000002
-#define        SNDBUF_F_RUNNING        0x00000004

In D53521#1221996, @emaste wrote:
The other constants were removed in the refactoring in e4e61333ffa4e90360de2dd1e4e0146f7cbf0afb
-#define        SNDBUF_F_DMA            0x00000001
-#define        SNDBUF_F_XRUN           0x00000002
-#define        SNDBUF_F_RUNNING        0x00000004

So it's better to leave it as is? Not sure there is good reason to do so, these are internal anyway.

So it's better to leave it as is? Not sure there is good reason to do so, these are internal anyway.

Oops, I had another comment that I deleted accidentally before I submitted. I was just wondering if there's any chance this will be used in an out-of-tree module, or it's entirely internal to the snd infrastructure.

Anyhow I think it doesn't really matter if flags 1/2/4 are unused but I won't object to changing this if it has no external use/visibility.

emaste accepted this revision.Nov 1 2025, 10:57 PM

This revision is now accepted and ready to land.Nov 1 2025, 10:57 PM

markj accepted this revision.Sun, Nov 2, 4:14 PM

Closed by commit rGd159b023de52: sound: Define SNDBUF_F_MANAGED as 0x00000001 (authored by christos). · Explain WhyTue, Nov 11, 12:08 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGd159b023de52: sound: Define SNDBUF_F_MANAGED as 0x00000001.

christos added a commit: rG7ac082ff1ad9: sound: Define SNDBUF_F_MANAGED as 0x00000001.Tue, Nov 18, 12:52 AM