Page MenuHomeFreeBSD
Differential D53417

d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr
ClosedPublic
Actions

Authored by 0mp on Tue, Oct 28, 8:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 20, 2:00 AM
Unknown Object (File)
Thu, Nov 20, 2:00 AM
Unknown Object (File)
Thu, Nov 20, 1:59 AM
Unknown Object (File)
Thu, Nov 20, 1:54 AM
Unknown Object (File)
Sun, Nov 9, 6:32 PM
Unknown Object (File)
Sun, Nov 9, 6:26 PM
Unknown Object (File)
Wed, Nov 5, 12:18 PM
Unknown Object (File)
Wed, Nov 5, 12:18 PM
View All 24 Files
Subscribers
imp
markj
ziaee

Details

Reviewers
markj
Group Reviewers
DTrace
manpages
Commits
rGd086bf34b56f: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr
rGaf99c4c1d03c: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr
Summary

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Tue, Oct 28, 8:20 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptTue, Oct 28, 8:20 PM
0mp requested review of this revision.Tue, Oct 28, 8:20 PM
Harbormaster completed remote builds in B68191: Diff 165253.Tue, Oct 28, 8:20 PM
0mp added reviewers: DTrace, manpages.Tue, Oct 28, 8:20 PM
markj added a subscriber: markj.Wed, Oct 29, 1:24 PM
markj added inline comments.
share/man/man7/d.7
208

What is returned if there is no match? NULL, or the empty string?

217

I don't think the comparison to strcat is useful. (Really, the comparisons to C functions in general isn't useful IMO: if you know C, then these functions are familiar, and if you don't the comparisons mean nothing.)

0mp updated this revision to Diff 165571.Fri, Oct 31, 2:00 PM
  • Add examples
  • Do not refer to C functions
  • Explain return values
Harbormaster completed remote builds in B68306: Diff 165571.Fri, Oct 31, 2:00 PM
0mp marked 2 inline comments as done.Fri, Oct 31, 2:01 PM
0mp added inline comments.
share/man/man7/d.7
208

I've added those details.

217

Good point. Thanks! I removed those pointers.

0mp marked 2 inline comments as done.Fri, Oct 31, 2:01 PM
markj accepted this revision as: markj.Sun, Nov 2, 5:09 PM
This revision is now accepted and ready to land.Sun, Nov 2, 5:09 PM
0mp added a comment.Sun, Nov 2, 7:21 PM

Awesome! Thanks, Mark!

Closed by commit rGaf99c4c1d03c: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr (authored by 0mp). · Explain WhySun, Nov 2, 7:22 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rGaf99c4c1d03c: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr.
0mp added a commit: rGd086bf34b56f: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr.Tue, Nov 18, 1:38 PM

Revision Contents
Changeset List

PathSize
share/
man/
man7/
124 lines

Diff 165690

View Options

share/man/man7/d.7

Loading...