ClosedPublic
Actions

Authored by fuz on Fri, Oct 17, 9:33 AM.

Details

Reviewers

andrew
cognet
markj

Commits

rG3c8ae8b1c956: sys/arm: add fp[gs]et* prototypes to <ieeefp.h>
rG0da1b6cfcc1d: sys/arm: add fp[gs]et* prototypes to <ieeefp.h>
rGaf39e511ee15: sys/arm: add fp[gs]et* prototypes to <ieeefp.h>
rGa8079d40ae7f: sys/arm: add fp[gs]et* prototypes to <ieeefp.h>

Summary

We have provided implementations for hard float of these for
a while now. Add them to the header to make things official.
This is required for a bunch of legacy programs in ports.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fuz created this revision.Fri, Oct 17, 9:33 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 17, 9:33 AM

fuz requested review of this revision.Fri, Oct 17, 9:33 AM

Harbormaster completed remote builds in B67860: Diff 164387.Fri, Oct 17, 9:33 AM

fuz added a reviewer: cognet.Fri, Oct 17, 9:39 AM

I plan to MFC this one to 14. Is it appropriate to ask releng to have this included into 15.0?

Approved.

In D53156#1216344, @fuz wrote:

I plan to MFC this one to 14. Is it appropriate to ask releng to have this included into 15.0?

I think that would be ok.

BTW, can we remove the .if !defined(CPUTYPE) ... guard in lib/libc/arm/gen/Makefile.inc? I presume that that condition is always true (including on 14)?

This revision is now accepted and ready to land.Wed, Oct 22, 1:29 PM

In D53156#1216629, @markj wrote:

BTW, can we remove the .if !defined(CPUTYPE) ... guard in lib/libc/arm/gen/Makefile.inc? I presume that that condition is always true (including on 14)?

I'm pretty sure we can. ARM softfp is dead. I'll submit another review for that.

Closed by commit rGa8079d40ae7f: sys/arm: add fp[gs]et* prototypes to <ieeefp.h> (authored by fuz). · Explain WhyWed, Oct 22, 1:42 PM

This revision was automatically updated to reflect the committed changes.

fuz added a commit: rGa8079d40ae7f: sys/arm: add fp[gs]et* prototypes to <ieeefp.h>.

fuz added a commit: rGaf39e511ee15: sys/arm: add fp[gs]et* prototypes to <ieeefp.h>.Wed, Oct 29, 11:16 AM

fuz added a commit: rG0da1b6cfcc1d: sys/arm: add fp[gs]et* prototypes to <ieeefp.h>.

cperciva added a commit: rG3c8ae8b1c956: sys/arm: add fp[gs]et* prototypes to <ieeefp.h>.Thu, Oct 30, 4:24 AM