Page MenuHomeFreeBSD
Differential D53075

Ping: Make build reproducible
ClosedPublic
Actions

Authored by cperciva on Mon, Oct 13, 4:01 PM.
Tags
None
Referenced Files
F132458575: D53075.id164101.diff
Fri, Oct 17, 2:46 AM
F132458565: D53075.id164123.diff
Fri, Oct 17, 2:46 AM
F132458561: D53075.id.diff
Fri, Oct 17, 2:46 AM
Unknown Object (File)
Thu, Oct 16, 5:45 PM
Unknown Object (File)
Thu, Oct 16, 10:30 AM
Unknown Object (File)
Thu, Oct 16, 5:55 AM
Unknown Object (File)
Thu, Oct 16, 3:41 AM
Unknown Object (File)
Wed, Oct 15, 10:52 PM
View All 13 Files
Subscribers
imp

Details

Reviewers
bdrewery
emaste
jrtc27
kevans
Commits
rG6fc227a68bbd: Ping: Make build reproducible
rGa7c1d6b72a3e: Ping: Make build reproducible
rG3c9a2f383fc2: Ping: Make build reproducible
Summary

As recently fixed in sockstat (9934558460e4), having tests/Makefile
include files from the parent directory with SRCS= ../foo.c results
in a race condition as the parent build and the tests build try to
produce the same object file but contain different paths.

Use .PATH to tell make to find sockstat.c in the parent directory
but place the object file in the current object directory.

MFC after: 3 days
Sponsored by: https://www.patreon.com/cperciva

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cperciva created this revision.Mon, Oct 13, 4:01 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Oct 13, 4:01 PM
cperciva requested review of this revision.Mon, Oct 13, 4:01 PM
Harbormaster completed remote builds in B67758: Diff 164101.Mon, Oct 13, 4:01 PM
kevans accepted this revision.Mon, Oct 13, 7:03 PM
This revision is now accepted and ready to land.Mon, Oct 13, 7:03 PM
jrtc27 accepted this revision.Mon, Oct 13, 9:40 PM
jrtc27 added inline comments.
sbin/ping/tests/Makefile
3

I think convention is to put .PATH before the first need for it, not after? Doesn't functionally matter though.

emaste accepted this revision.Tue, Oct 14, 12:28 AM
emaste added inline comments.
sbin/ping/tests/Makefile
3

It's logical to put the .PATH before the source IMO, yeah.

Closed by commit rG3c9a2f383fc2: Ping: Make build reproducible (authored by cperciva). · Explain WhyTue, Oct 14, 2:53 AM
This revision was automatically updated to reflect the committed changes.
cperciva added a commit: rG3c9a2f383fc2: Ping: Make build reproducible.
cperciva added a commit: rGa7c1d6b72a3e: Ping: Make build reproducible.Thu, Oct 16, 8:03 PM
cperciva added a commit: rG6fc227a68bbd: Ping: Make build reproducible.Thu, Oct 16, 8:08 PM

Revision Contents
Changeset List

PathSize
sbin/
ping/
tests/
3 lines

Diff 164123

View Options

sbin/ping/tests/Makefile

Loading...