Paths

Table of Contentst

Differential D52954

rc tests: Add a test to check for warnings from rcorder
ClosedPublic
Actions

Authored by markj on Tue, Oct 7, 1:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 11, 9:01 AM

	Unknown Object (File)
	Sat, Oct 11, 5:39 AM

	Unknown Object (File)
	Fri, Oct 10, 5:16 PM

	Unknown Object (File)
	Fri, Oct 10, 5:16 PM

	Unknown Object (File)
	Fri, Oct 10, 5:15 PM

	Unknown Object (File)
	Fri, Oct 10, 5:15 PM

	Unknown Object (File)
	Fri, Oct 10, 11:59 AM

	Unknown Object (File)
	Thu, Oct 9, 12:34 PM

View All 16 Files

Subscribers

Details

Reviewers

asomers
des
0mp

Commits

rG04d47c7cde54: rc tests: Add a test to check for warnings from rcorder

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Tue, Oct 7, 1:22 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 7, 1:22 PM

markj requested review of this revision.Tue, Oct 7, 1:22 PM

markj added a parent revision: D52953: rc: Update dependencies for zpool scripts.

Harbormaster completed remote builds in B67609: Diff 163691.Tue, Oct 7, 1:22 PM

des added inline comments.Tue, Oct 7, 2:47 PM

libexec/rc/tests/rc_subr_test.sh
37	I would not include `/usr/local/etc/rc.d/*` here, and if I did I would not hardcode `/usr/local`, but use `${LOCALBASE:=$(sysctl -n user.localbase)}`.

Don't test /usr/local/etc/rc.d/*

Harbormaster completed remote builds in B67615: Diff 163701.Tue, Oct 7, 4:15 PM

des accepted this revision.Tue, Oct 7, 4:38 PM

This revision is now accepted and ready to land.Tue, Oct 7, 4:38 PM

Closed by commit rG04d47c7cde54: rc tests: Add a test to check for warnings from rcorder (authored by markj). · Explain WhyWed, Oct 8, 1:02 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG04d47c7cde54: rc tests: Add a test to check for warnings from rcorder.

Revision Contents
Changeset List

Path

Size

libexec/

rc/

tests/

rc_subr_test.sh

12 lines

Diff 163775

libexec/rc/tests/rc_subr_test.sh

Loading...