Page MenuHomeFreeBSD

nullfs: Apply comments from D38761 (style fixes, small improvements)
ClosedPublic

Authored by olce on Mon, Oct 6, 2:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 12:51 AM
Unknown Object (File)
Fri, Oct 10, 12:51 AM
Unknown Object (File)
Fri, Oct 10, 12:51 AM
Unknown Object (File)
Fri, Oct 10, 12:36 AM
Unknown Object (File)
Thu, Oct 9, 8:40 PM
Unknown Object (File)
Thu, Oct 9, 5:52 PM
Unknown Object (File)
Tue, Oct 7, 4:12 PM
Unknown Object (File)
Tue, Oct 7, 12:24 AM
Subscribers

Details

Summary

In two commits:

nullfs: Fix some style after recent changes

In 'nullfs_subr.c':
- Sort the headers.
- Use '__func__' in preference to the function's name in an assertion.

This applies comments from D38761, one of which was missed and the other
added too late.

MFC with:       249ec85352b5 ("nullfs: smr-protected hash lookup")
Sponsored by:   The FreeBSD Foundation
nullfs: Slightly reduce contention by reducing concurrent sections

In null_lock_prep_with_smr(), initialize 'lvp' outside of the
SMR-protected section.

In null_lock(), if after locking the lower vnode we notice that we have
been reclaimed, we have to unlock the lower vnode and then relock our
own now that the lock isn't shared anymore.  Call VOP_UNLOCK() on the
lower vnode as soon as this condition is known.

This applies comments from D38761, one of which was missed and the other
added too late.

MFC with:       641a58239520 ("nullfs: avoid the interlock in null_lock with smr")
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67588
Build 64471: arc lint + arc unit

Event Timeline

olce requested review of this revision.Mon, Oct 6, 2:50 PM
kib added inline comments.
sys/fs/nullfs/null_subr.c
39

Can be rwlock.h moved?

This revision is now accepted and ready to land.Mon, Oct 6, 3:04 PM
olce marked an inline comment as done.Mon, Oct 6, 3:19 PM
olce added inline comments.
sys/fs/nullfs/null_subr.c
39

Sure. Missed this pre-existing problem.