MFC after: 3 days
Sponsored by: Klara, Inc.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I especially welcome feedback on whether the added text is in the correct place. Unlike e.g. Solaris, we don't have a tradition of including a section on signal or thread safety in our manual pages, so it wasn't immediately obvious to me where to put it. It's not a bug or a security consideration, and I feel that it's too important to bury in a caveat. It could arguably be an implementation note, since we could have chosen to add a mutex to FTS and FTSENT.
Comment Actions
The text looks ok to me. I don't have any strong feelings on where best to put the note, and this page is a bit unconventional already (each function is a top-level section...?).
IMPLEMENTATION NOTES is ok, but maybe a bit misleading: even though this thread-safety property of the interface is an implementation detail, we can't presumably remove it without breaking compatibility, so it's effectively a guarantee of the interface.