rk_gpio: Fix register read/write on rk3568

[devivanov_proton.me]

Summary

Not all registers have a write mask with high/low register on rk3568.

Test Plan

Tested via gpioctl(1). This bug effected gpio inputs >= 16 as well as interrupts >= 16

[vexeduxr]

sys/arm64/rockchip/rk_gpio.c

146

This should be a pointer, instead of copying the struct.

[devivanov_proton.me]

sys/arm64/rockchip/rk_gpio.c

146

Is it better when the struct is only 2 bytes?

[vexeduxr]

sys/arm64/rockchip/rk_gpio.c

146

I don't think it would matter much. At the end of the day the assembly will look very similar once optimized. But in theory, one copies the struct to the stack then reads it's members by dereferencing offsets on the stack, while the other reads it's members by dereferencing offsets on the passed pointer.

[devivanov_proton.me]

Use a reference instead of copying struct

[vexeduxr]

I don't have the hardware to test this, but cross referencing the documentation, it looks good to me.

sys/arm64/rockchip/rk_gpio.c

180

Are we intentionally not preserving the old value here?