tty: Retire zombie dtrwait
ClosedPublic
Actions

Authored by imp on Aug 31 2025, 11:44 PM.

Details

Reviewers

emaste
kevans

Commits

rG4b4cf0d52c43: tty: Retire zombie dtrwait

Summary

Nothing uses dtrwait anymore. This was elimianted with the tty mpsafe
rewrite for FreeBSD 8. Only these zombie symbols and functionality
remain. GC them.

Maybe we can gc comcontrol(8) entirely...

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Aug 31 2025, 11:44 PM

Herald added a subscriber: ziaee. · View Herald TranscriptAug 31 2025, 11:44 PM

imp requested review of this revision.Aug 31 2025, 11:44 PM

Harbormaster completed remote builds in B66731: Diff 161310.Aug 31 2025, 11:44 PM

imp added a parent revision: D52316: rc.d/serial: Kill dtrwait.Aug 31 2025, 11:44 PM

emaste accepted this revision.Sep 2 2025, 3:46 PM

emaste added a subscriber: emaste.

emaste added inline comments.

sys/sys/ttycom.h
72–73	Maybe worth keeping `TIOCMGDTRWAIT` in the comment about what it was?

This revision is now accepted and ready to land.Sep 2 2025, 3:46 PM

How about we cut a deal: if you slap a deprecation on comcontrol is 15.0, I'll look at adding drainwait configuration to stty(1) to replace it. We don't need to maintain a special command to "control a special tty device" for a configuration item that's implemented in the tty layer.

In D52317#1195163, @kevans wrote:

How about we cut a deal: if you slap a deprecation on comcontrol is 15.0, I'll look at adding drainwait configuration to stty(1) to replace it. We don't need to maintain a special command to "control a special tty device" for a configuration item that's implemented in the tty layer.

Done. Will update.

update per review

This revision now requires review to proceed.Sep 2 2025, 9:20 PM

update per review, maybe twice

Harbormaster completed remote builds in B66771: Diff 161397.Sep 2 2025, 9:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2025, 5:18 AM

Closed by commit rG4b4cf0d52c43: tty: Retire zombie dtrwait (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG4b4cf0d52c43: tty: Retire zombie dtrwait.