cr_canseeothergids(): Make the logic easier to grasp
ClosedPublic
Actions

Authored by olce on Aug 29 2025, 11:03 PM.

Details

Reviewers

kevans
emaste

Commits

rG560c1bb21fe2: cr_canseeothergids(): Make the logic easier to grasp
rG7bab0263aafe: cr_canseeothergids(): Make the logic easier to grasp
rGf75d0dc53392: cr_canseeothergids(): Make the logic easier to grasp

Summary

Revert the initial test on whether the policy is in force so that, if
there are no restrictions, the function bails out early, allowing to
de-indent the rest of the code and have it finish with a non-zero (deny)
'return'.

No functional change (intended).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Aug 29 2025, 11:03 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 29 2025, 11:03 PM

olce requested review of this revision.Aug 29 2025, 11:03 PM

Harbormaster completed remote builds in B66675: Diff 161238.Aug 29 2025, 11:03 PM

olce added a parent revision: D52268: cred: Restore proper checking of effective groups in some security policies.Sep 1 2025, 3:43 PM

olce added a reviewer: emaste.Sep 1 2025, 4:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2025, 12:21 PM

Closed by commit rGf75d0dc53392: cr_canseeothergids(): Make the logic easier to grasp (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGf75d0dc53392: cr_canseeothergids(): Make the logic easier to grasp.

olce added a commit: rG7bab0263aafe: cr_canseeothergids(): Make the logic easier to grasp.Sep 23 2025, 12:04 PM

olce added a commit: rG560c1bb21fe2: cr_canseeothergids(): Make the logic easier to grasp.Oct 10 2025, 5:16 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_prot.c

23 lines

Diff 162241

View Options

cr_canseeothergids(): Make the logic easier to graspClosedPublicActions