Differential D52269

cred: 'struct ucred': Rework comment on 'cr_gid'/cr_groups[]
ClosedPublic
Actions

Authored by olce on Aug 29 2025, 11:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 17, 2:15 AM

	Unknown Object (File)
	Wed, Apr 15, 1:53 PM

	Unknown Object (File)
	Tue, Apr 14, 11:21 AM

	Unknown Object (File)
	Sun, Apr 5, 9:10 AM

	Unknown Object (File)
	Sun, Apr 5, 6:34 AM

	Unknown Object (File)
	Mar 19 2026, 1:31 PM

	Unknown Object (File)
	Mar 15 2026, 7:52 AM

	Unknown Object (File)
	Mar 15 2026, 1:03 AM

View All 61 Files

Subscribers

Details

Reviewers

Commits

rGee8c31c6dae4: cred: 'struct ucred': Rework comment on 'cr_gid'/cr_groups[]
rG0abeb8d8d8df: cred: 'struct ucred': Rework comment on 'cr_gid'/cr_groups[]

Summary

Make it more straightforward for consumers. Also, recommend using
cr_sgroups[] for supplementary groups, as this can generally alleviate
index problems and will help us spot and change consumers if/when
'struct ucred' is evolved incompatibly (and cr_sgroups[] suppressed).

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Aug 29 2025, 11:03 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 29 2025, 11:03 PM

olce requested review of this revision.Aug 29 2025, 11:03 PM

Harbormaster completed remote builds in B66672: Diff 161235.Aug 29 2025, 11:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2025, 12:21 PM

Closed by commit rG0abeb8d8d8df: cred: 'struct ucred': Rework comment on 'cr_gid'/cr_groups[] (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG0abeb8d8d8df: cred: 'struct ucred': Rework comment on 'cr_gid'/cr_groups[].

olce added a commit: rGee8c31c6dae4: cred: 'struct ucred': Rework comment on 'cr_gid'/cr_groups[].Sep 23 2025, 12:04 PM

Revision Contents
Changeset List

Path

Size

sys/

sys/

14 lines

Diff 162238

sys/sys/ucred.h

Loading...