Page MenuHomeFreeBSD
Differential D52257

procfs: Restore printing the effective GID in 'status'
ClosedPublic
Actions

Authored by olce on Aug 29 2025, 11:02 PM.
Tags
None
Referenced Files
F171072086: D52257.diff
Tue, Sep 8, 1:08 PM
Unknown Object (File)
Mon, Sep 7, 5:11 AM
Unknown Object (File)
Mon, Sep 7, 2:29 AM
Unknown Object (File)
Mon, Sep 7, 2:26 AM
Unknown Object (File)
Sun, Sep 6, 2:38 PM
Unknown Object (File)
Sun, Sep 6, 4:11 AM
Unknown Object (File)
Sat, Sep 5, 3:43 PM
Unknown Object (File)
Sat, Sep 5, 7:43 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
kevans
kib
Commits
rG79c1160fb9f2: procfs: Restore printing the effective GID in 'status'
rGd859d4c57eda: procfs: Restore printing the effective GID in 'status'
Summary

Fixes: be1f7435ef218b1d ("kern: start tracking cr_gid outside of cr_groups[]")
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Aug 29 2025, 11:02 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 29 2025, 11:02 PM
olce requested review of this revision.Aug 29 2025, 11:02 PM
Harbormaster completed remote builds in B66660: Diff 161223.Aug 29 2025, 11:02 PM
olce added a reviewer: kib.Sep 1 2025, 3:39 PM
kib accepted this revision.Sep 1 2025, 4:01 PM
This revision is now accepted and ready to land.Sep 1 2025, 4:01 PM
kib added a comment.Sep 1 2025, 4:02 PM

Does linprocfs have the same issue? I mean compat/linprocfs/linprocfs.c:1136

olce added a comment.Sep 1 2025, 4:21 PM
In D52257#1194563, @kib wrote:

Does linprocfs have the same issue? I mean compat/linprocfs/linprocfs.c:1136

It doesn't as it already has been printing cr_gid separately, and then the content of cr_groups[].

That also means that before it would output the effective GID twice, but after our changes, the latter will disappear from the "Groups" part if not also a supplementary group. This is actually a "free" bugfix, as Linux does not output the effective GID twice.

Closed by commit rGd859d4c57eda: procfs: Restore printing the effective GID in 'status' (authored by olce). · Explain WhySep 9 2025, 3:58 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rGd859d4c57eda: procfs: Restore printing the effective GID in 'status'.
olce added a commit: rG79c1160fb9f2: procfs: Restore printing the effective GID in 'status'.Sep 18 2025, 8:53 AM

Revision Contents
Changeset List

PathSize
sys/
fs/
procfs/
8 lines

Diff 161806

View Options

sys/fs/procfs/procfs_status.c

Loading...