Page MenuHomeFreeBSD

umb: Fix setting the input routine
ClosedPublic

Authored by zlei on Aug 27 2025, 4:49 PM.
Tags
None
Referenced Files
F165582157: D52182.id161046.diff
Sat, Aug 8, 5:44 PM
F165437996: D52182.id161046.diff
Sat, Aug 8, 5:17 AM
Unknown Object (File)
Wed, Aug 5, 7:44 AM
Unknown Object (File)
Wed, Aug 5, 6:24 AM
Unknown Object (File)
Tue, Aug 4, 5:13 PM
Unknown Object (File)
Tue, Aug 4, 7:10 AM
Unknown Object (File)
Mon, Jul 27, 7:35 AM
Unknown Object (File)
Sat, Jul 25, 9:51 AM
Subscribers

Details

Summary

This driver does not depend on netmap, and umb_input() works greatly
without netmap.

Remove the #ifdef DEV_NETMAP so that when "device netmap" is not
configured this driver can still correctly pass the inbound packets to
the net stack. Otherwise the input routine will be if_input_default()
which will silently drop all inbound packets.

PR: 263783
Reported by: Andre Albsmeier <mail@fbsd2.e4m.org>
Tested by: Andre Albsmeier <mail@fbsd2.e4m.org>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Aug 27 2025, 4:49 PM

I'd like to have the fix in main before making the stable/15 branch. Please do not hesitate to ping me.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2025, 5:20 PM
This revision was automatically updated to reflect the committed changes.