Differential D52182

umb: Fix setting the input routine
ClosedPublic
Actions

Authored by zlei on Aug 27 2025, 4:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 6, 10:52 PM

	Unknown Object (File)
	Sat, Nov 29, 11:08 PM

	Unknown Object (File)
	Fri, Nov 28, 10:56 PM

	Unknown Object (File)
	Sun, Nov 23, 5:56 AM

	Unknown Object (File)
	Oct 29 2025, 11:21 AM

	Unknown Object (File)
	Oct 29 2025, 9:07 AM

	Unknown Object (File)
	Oct 29 2025, 9:06 AM

	Unknown Object (File)
	Oct 29 2025, 8:45 AM

View All 28 Files

Subscribers

Details

Reviewers

khorben
philip

Group Reviewers

Commits

rGe921d2842ee8: umb: Fix setting the input routine

Summary

This driver does not depend on netmap, and umb_input() works greatly
without netmap.

Remove the #ifdef DEV_NETMAP so that when "device netmap" is not
configured this driver can still correctly pass the inbound packets to
the net stack. Otherwise the input routine will be if_input_default()
which will silently drop all inbound packets.

PR: 263783
Reported by: Andre Albsmeier <mail@fbsd2.e4m.org>
Tested by: Andre Albsmeier <mail@fbsd2.e4m.org>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Aug 27 2025, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2025, 4:49 PM

zlei requested review of this revision.Aug 27 2025, 4:49 PM

I'd like to have the fix in main before making the stable/15 branch. Please do not hesitate to ping me.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2025, 5:20 PM

Closed by commit rGe921d2842ee8: umb: Fix setting the input routine (authored by zlei). · Explain Why

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGe921d2842ee8: umb: Fix setting the input routine.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

net/

4 lines

Diff 161441

sys/dev/usb/net/if_umb.c

Loading...