Differential D52181

bsd.man.mk: Handle MANSRC.{TARGET} for MK_MANCOMPRESS=no and empty MANBUILDCAT
ClosedPublic
Actions

Authored by jhb on Aug 27 2025, 3:48 PM.

Tags

None

Referenced Files

	F154130820: D52181.id161042.diff
	Sun, Apr 26, 10:21 AM

	F154096902: D52181.id161042.diff
	Sun, Apr 26, 4:02 AM

	Unknown Object (File)
	Tue, Apr 21, 11:17 AM

	Unknown Object (File)
	Tue, Apr 21, 5:18 AM

	Unknown Object (File)
	Mon, Apr 20, 4:30 PM

	Unknown Object (File)
	Mon, Apr 20, 4:25 PM

	Unknown Object (File)
	Mon, Apr 20, 12:13 AM

	Unknown Object (File)
	Sun, Apr 19, 6:39 PM

View All 70 Files

Subscribers

Details

Reviewers

Commits

rG557cc0f350e7: bsd.man.mk: Handle MANSRC.{TARGET} for MK_MANCOMPRESS=no and empty MANBUILDCAT

Summary

Fixes: 65f60d715fd9 ("bsd.man.mk: Add a MANSRC.{TARGET} variable")
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Aug 27 2025, 3:48 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptAug 27 2025, 3:48 PM

jhb requested review of this revision.Aug 27 2025, 3:48 PM

Harbormaster completed remote builds in B66563: Diff 161042.Aug 27 2025, 3:48 PM

kevans accepted this revision.Aug 27 2025, 4:00 PM

kevans added inline comments.

share/mk/bsd.man.mk
174	I'd be tempted to simplify (and the dependency below could drop the :U if so), but I do not insist. I can't think of a scenario where we'd set MANSRC for a page with a 1:1 match.

This revision is now accepted and ready to land.Aug 27 2025, 4:00 PM

jhb added inline comments.Aug 27 2025, 5:55 PM

share/mk/bsd.man.mk
174	Oh, that's fair.

Simplify and add CLEANFILES

This revision now requires review to proceed.Aug 27 2025, 5:59 PM

Harbormaster completed remote builds in B66575: Diff 161058.Aug 27 2025, 5:59 PM

jhb marked an inline comment as done.Aug 27 2025, 5:59 PM

Thanks!

This revision is now accepted and ready to land.Aug 27 2025, 6:41 PM

Closed by commit rG557cc0f350e7: bsd.man.mk: Handle MANSRC.{TARGET} for MK_MANCOMPRESS=no and empty MANBUILDCAT (authored by jhb). · Explain WhyAug 27 2025, 8:12 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG557cc0f350e7: bsd.man.mk: Handle MANSRC.{TARGET} for MK_MANCOMPRESS=no and empty MANBUILDCAT.

Revision Contents
Changeset List

Path

Size

share/

mk/

11 lines

Diff 161077

share/mk/bsd.man.mk

Loading...