Page MenuHomeFreeBSD
Differential D52151

ng_parse: Add upper bound to avoid possible overflow
ClosedPublic
Actions

Authored by emaste on Aug 25 2025, 2:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 3:46 AM
Unknown Object (File)
Fri, Oct 10, 5:42 AM
Unknown Object (File)
Fri, Oct 10, 5:42 AM
Unknown Object (File)
Fri, Oct 10, 5:42 AM
Unknown Object (File)
Fri, Oct 10, 5:42 AM
Unknown Object (File)
Fri, Oct 10, 12:09 AM
Unknown Object (File)
Thu, Oct 9, 9:35 PM
Unknown Object (File)
Wed, Oct 8, 8:52 PM
View All 26 Files
Subscribers
des
donner
glebius
imp
melifaro

Details

Reviewers
des
Commits
rGe3af3a23c155: ng_parse: Add upper bound to avoid possible overflow
rG4407e10fdc8b: ng_parse: Add upper bound to avoid possible overflow
rG375527545c85: ng_parse: Add upper bound to avoid possible overflow
Summary

Also move num initialization to make it more clear.

Suggested by: @des
PR: 467334

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Aug 25 2025, 2:47 PM
Herald added subscribers: glebius, melifaro, donner. · View Herald TranscriptAug 25 2025, 2:47 PM
emaste requested review of this revision.Aug 25 2025, 2:47 PM

Keeping num const is desirable IMO but we can indeed sort it after the other variables.

des added inline comments.Aug 25 2025, 3:24 PM
sys/netgraph/ng_parse.c
1382

Do we know that we can trust num here? because if not...

1401

...then we are blindly indexing an array here without checking if we're within bounds.

1539

pre-existing style nit here

1545

pre-existing style nit here

emaste added inline comments.Aug 28 2025, 2:21 PM
sys/netgraph/ng_parse.c
1382

It's been something like two decades since I've looked at netgraph in depth, so I'm not really sure. Should definitely look into this but I'd like to commit this review as an improvement independent of that question.

1539

It seems ng_parse.c omits the () on all or nearly all return statements so I'm not inclined to change this

des accepted this revision.Aug 29 2025, 9:41 AM
This revision is now accepted and ready to land.Aug 29 2025, 9:41 AM
Closed by commit rG375527545c85: ng_parse: Add upper bound to avoid possible overflow (authored by emaste). · Explain WhySep 1 2025, 9:13 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG375527545c85: ng_parse: Add upper bound to avoid possible overflow.
Herald added a subscriber: imp. · View Herald TranscriptSep 1 2025, 9:13 PM
emaste added a commit: rG4407e10fdc8b: ng_parse: Add upper bound to avoid possible overflow.Sep 4 2025, 1:01 PM
emaste added a commit: rGe3af3a23c155: ng_parse: Add upper bound to avoid possible overflow.Sep 4 2025, 1:06 PM

Revision Contents
Changeset List

PathSize
sys/
netgraph/
4 lines

Diff 161344

View Options

sys/netgraph/ng_parse.c

Loading...