Differential D5205

ixl(4): Fix potential driver interrupt setup issues and startup crash.
ClosedPublic
Actions

Authored by erj on Feb 5 2016, 10:54 PM.

Tags

None

Referenced Files

	F168226975: D5205.id13071.diff
	Thu, Aug 27, 1:18 AM

	Unknown Object (File)
	Wed, Aug 26, 5:32 AM

	Unknown Object (File)
	Tue, Aug 25, 11:18 PM

	Unknown Object (File)
	Tue, Aug 25, 12:58 PM

	Unknown Object (File)
	Thu, Aug 13, 5:18 AM

	Unknown Object (File)
	Wed, Aug 12, 11:22 PM

	Unknown Object (File)
	Sun, Aug 9, 7:26 PM

	Unknown Object (File)
	Sun, Aug 9, 8:49 AM

Subscribers

jeffrey.e.pieper_intel.com

Details

Reviewers

jeffrey.e.pieper_intel.com
sbruno
smh

Group Reviewers

Intel Networking

Summary

Limit queue autoconfiguration to 8 queues to prevent the driver from requesting a large number of MSI-X vectors at boot.

Fix potential kernel panic when loading the driver and the driver cannot setup all requested MSIX vectors. Instead, attach() should exit with a failure code.
- Move taskqueue setup to later in attach() to prevent having to free taskqueues if another error later in attach() occurs.

Test Plan

-Reboot/attach/init tests using default MSIX vectors.
-Reboot/attach/init tests using user-defined MSIX vectors (not to exceed 184).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2404
Build 2420: arc lint + arc unit

Event Timeline

erj updated this revision to Diff 13071.Feb 5 2016, 10:54 PM

erj retitled this revision from to ixl(4): Fix potential driver interrupt setup issues and startup crash..

erj updated this object.

Herald added a reviewer: Intel Networking. · View Herald TranscriptFeb 5 2016, 10:54 PM

Herald added a subscriber: imp. · View Herald Transcript

erj edited the test plan for this revision. (Show Details)Feb 5 2016, 10:55 PM

erj added reviewers: jeffrey.e.pieper_intel.com, gnn.

erj added a subscriber: jeffrey.e.pieper_intel.com.

jeffrey.e.pieper_intel.com edited the test plan for this revision. (Show Details)Feb 9 2016, 2:23 AM

jeffrey.e.pieper_intel.com accepted this revision.Feb 10 2016, 6:55 PM

jeffrey.e.pieper_intel.com edited edge metadata.

This revision is now accepted and ready to land.Feb 10 2016, 6:55 PM

erj edited reviewers, added: sbruno; removed: gnn.Feb 19 2016, 11:23 PM

erj added a reviewer: smh.

erj mentioned this in D5211: import iflib.Feb 22 2016, 7:43 PM

Committed in rS295946.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

102 lines

Diff 13071

sys/dev/ixl/if_ixl.c

Loading...