Page MenuHomeFreeBSD

ixl(4): Fix potential driver interrupt setup issues and startup crash.
ClosedPublic

Authored by erj on Feb 5 2016, 10:54 PM.
Tags
None
Referenced Files
F173003876: D5205.diff
Tue, Sep 22, 7:27 PM
Unknown Object (File)
Sun, Sep 20, 7:17 AM
Unknown Object (File)
Wed, Sep 16, 11:17 AM
Unknown Object (File)
Wed, Sep 9, 10:37 PM
Unknown Object (File)
Sat, Sep 5, 3:13 PM
Unknown Object (File)
Sat, Sep 5, 9:35 AM
Unknown Object (File)
Fri, Sep 4, 6:38 PM
Unknown Object (File)
Thu, Sep 3, 1:47 PM

Details

Summary
  • Limit queue autoconfiguration to 8 queues to prevent the driver from requesting a large number of MSI-X vectors at boot.
  • Fix potential kernel panic when loading the driver and the driver cannot setup all requested MSIX vectors. Instead, attach() should exit with a failure code.
    • Move taskqueue setup to later in attach() to prevent having to free taskqueues if another error later in attach() occurs.
Test Plan

-Reboot/attach/init tests using default MSIX vectors.
-Reboot/attach/init tests using user-defined MSIX vectors (not to exceed 184).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2404
Build 2420: arc lint + arc unit

Event Timeline

erj retitled this revision from to ixl(4): Fix potential driver interrupt setup issues and startup crash..
erj updated this object.
erj added a subscriber: jeffrey.e.pieper_intel.com.
This revision is now accepted and ready to land.Feb 10 2016, 6:55 PM
erj added a reviewer: smh.