re: Make sure re_rxeof() is called in net epoch context
ClosedPublic
Actions

Authored by markj on Aug 13 2025, 2:44 PM.

Details

Reviewers

adrian
glebius
zlei

Group Reviewers

network

Commits

rG4008dd50c8f9: re: Make sure re_rxeof() is called in net epoch context
rG0ab811d89311: re: Make sure re_rxeof() is called in net epoch context
rGb653a281f5a9: re: Make sure re_rxeof() is called in net epoch context

Summary

It may pass packets up the stack and so needs to be called in a network
epoch. When a watchdog timeout happens, we need to enter a section
explicitly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 13 2025, 2:44 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 13 2025, 2:44 PM

markj requested review of this revision.Aug 13 2025, 2:44 PM

Harbormaster completed remote builds in B66212: Diff 160296.Aug 13 2025, 2:44 PM

good catch!

This revision is now accepted and ready to land.Aug 13 2025, 2:52 PM

glebius accepted this revision.Aug 13 2025, 5:24 PM

zlei accepted this revision.Aug 14 2025, 2:18 AM

zlei added a subscriber: zlei.

zlei added inline comments.

sys/dev/re/if_re.c
3582	Well, I thought the entire `re_watchdog()` should be in net epoch section, but `re_detach()` has done the right thing so the `ifp` and its related members are guaranteed to be alive, so let `re_rxeof()` be in net epoch section should be sufficient.