Page MenuHomeFreeBSD
Differential D51773

rpcbind: Code cleanup
ClosedPublic
Actions

Authored by des on Aug 6 2025, 9:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 12:07 AM
Unknown Object (File)
Sat, Oct 11, 12:06 AM
Unknown Object (File)
Sat, Oct 11, 12:06 AM
Unknown Object (File)
Sat, Oct 11, 12:06 AM
Unknown Object (File)
Fri, Oct 10, 5:40 PM
Unknown Object (File)
Sat, Oct 4, 11:00 AM
Unknown Object (File)
Wed, Oct 1, 8:35 PM
Unknown Object (File)
Sep 15 2025, 10:00 AM
View All 19 Files
Subscribers
imp

Details

Reviewers
glebius
khng
kib
andrew
Commits
rG7378290edb5a: rpcbind: Code cleanup
Summary

Fix a number of style issues and attempt to reduce the diff to NetBSD.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Aug 6 2025, 9:30 PM
Herald added a reviewer: andrew. · View Herald TranscriptAug 6 2025, 9:30 PM
Herald added a subscriber: imp. · View Herald Transcript
des requested review of this revision.Aug 6 2025, 9:30 PM
Harbormaster completed remote builds in B66040: Diff 159914.Aug 6 2025, 9:30 PM
kib added inline comments.Aug 6 2025, 10:20 PM
usr.sbin/rpcbind/check_bound.c
67

Can it be const?

usr.sbin/rpcbind/rpcb_svc_4.c
401
421
423–424

The label should be on dedicated line.

usr.sbin/rpcbind/rpcbind.h
159

We have __DECONST(), which is more correct (cast through uintptr_t instead of long, I believe this breaks cheri). Can it be used there instead? Or at least __UNCONST can be defined as __DECONST(void *, _).

glebius accepted this revision.Aug 6 2025, 10:38 PM

No objection.

This revision is now accepted and ready to land.Aug 6 2025, 10:38 PM
des marked 5 inline comments as done.Aug 7 2025, 12:08 AM
des added inline comments.
usr.sbin/rpcbind/check_bound.c
67

Not without significant additional changes in this and other translation units.

des updated this revision to Diff 159934.Aug 7 2025, 12:09 AM
des marked an inline comment as done.

review feedback

This revision now requires review to proceed.Aug 7 2025, 12:09 AM
Harbormaster completed remote builds in B66049: Diff 159934.Aug 7 2025, 12:10 AM
kib accepted this revision.Aug 7 2025, 12:33 AM
This revision is now accepted and ready to land.Aug 7 2025, 12:33 AM
Closed by commit rG7378290edb5a: rpcbind: Code cleanup (authored by des). · Explain WhyAug 7 2025, 1:26 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG7378290edb5a: rpcbind: Code cleanup.

Revision Contents
Changeset List

PathSize
usr.sbin/
rpcbind/
23 lines
38 lines
15 lines
13 lines
30 lines
288 lines
42 lines
466 lines
12 lines

Diff 159936

View Options

usr.sbin/rpcbind/check_bound.c

Loading...
View Options

usr.sbin/rpcbind/pmap_svc.c

Loading...
View Options

usr.sbin/rpcbind/rpcb_stat.c

Loading...
View Options

usr.sbin/rpcbind/rpcb_svc.c

Loading...
View Options

usr.sbin/rpcbind/rpcb_svc_4.c

Loading...
View Options

usr.sbin/rpcbind/rpcb_svc_com.c

Loading...
View Options

usr.sbin/rpcbind/rpcbind.h

Loading...
View Options

usr.sbin/rpcbind/rpcbind.c

Loading...
View Options

usr.sbin/rpcbind/warmstart.c

Loading...