Differential D51720

p9fs: Set vnode state in p9fs_vget_common()
ClosedPublic
Actions

Authored by markj on Aug 4 2025, 3:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 11, 6:56 PM

	Unknown Object (File)
	Sun, Aug 9, 7:04 PM

	Unknown Object (File)
	Sun, Aug 9, 7:54 AM

	Unknown Object (File)
	Sun, Aug 9, 5:17 AM

	Unknown Object (File)
	Sun, Aug 9, 1:37 AM

	Unknown Object (File)
	Sat, Aug 8, 10:12 AM

	Unknown Object (File)
	Fri, Aug 7, 10:28 PM

	Unknown Object (File)
	Fri, Aug 7, 6:03 PM

View All 85 Files

Subscribers

Details

Reviewers

kib
dfr

Commits

rG0188e350666d: p9fs: Set vnode state in p9fs_vget_common()
rGe2ac6de6e4ed: p9fs: Set vnode state in p9fs_vget_common()

Summary

Once a new vnode is visible from the mountpoint hash, we should set its
state from VSTATE_UNINITIALIZED to VSTATE_CONSTRUCTED. I do not think
this affects correctness at all, but the bug trips a check in
vop_unlock_debugpost(), previously hidden under options DEBUG_VFS_LOCKS.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 4 2025, 3:14 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 4 2025, 3:14 PM

markj requested review of this revision.Aug 4 2025, 3:14 PM

Harbormaster completed remote builds in B65945: Diff 159710.Aug 4 2025, 3:14 PM

kib accepted this revision.Aug 4 2025, 8:17 PM

This revision is now accepted and ready to land.Aug 4 2025, 8:17 PM

Closed by commit rGe2ac6de6e4ed: p9fs: Set vnode state in p9fs_vget_common() (authored by markj). · Explain WhyAug 4 2025, 10:10 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGe2ac6de6e4ed: p9fs: Set vnode state in p9fs_vget_common().

markj added a commit: rG0188e350666d: p9fs: Set vnode state in p9fs_vget_common().Aug 12 2025, 12:57 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

p9fs/

2 lines

Diff 159729

sys/fs/p9fs/p9fs_vfsops.c

Loading...